Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What changed in v2? Please document breaking changes #12260

Closed
2 tasks done
barbalex opened this issue Jul 24, 2018 · 7 comments
Closed
2 tasks done

What changed in v2? Please document breaking changes #12260

barbalex opened this issue Jul 24, 2018 · 7 comments
Labels
status: waiting for author Issue with insufficient information

Comments

@barbalex
Copy link

barbalex commented Jul 24, 2018

  • This is a v2.x issue.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

Expect to find either documented realeases or a changelog file.

Current Behavior

There seems to be no documentation on breaking changes.

Context

I just updated to v2 and get an error:

Module not found: Can't resolve '@material-ui/core/SvgIcon' in 'C:\Users\alexa\node_modules\@material-ui\icons\utils'

So I need to revert to 1.1.0.

Seems weird that the icon is missed from the parent folder though: My project is situated at C:\Users\alexa\node_modules\apf2

@oliviertassinari oliviertassinari added the status: waiting for author Issue with insufficient information label Jul 24, 2018
@oliviertassinari
Copy link
Member

What changed in v2?

@barbalex We have updated the icons to reflect what's available on https://material.io/tools/icons/. There are 5,000 icons. It's the best we can do. Some icons are no longer present, some icons have a different name, some new icons are available.

Please provide a full reproduction test case. This would help a lot 👷 .
A live example would be perfect. This codesandbox.io template may be a good starting point. Thank you!

@oliviertassinari
Copy link
Member

After many iterations, we are happy to announce @material-ui/icons v2.0.0 💃.
With this version, you can take advantage of all the icons recently released by Google:
https://material.io/tools/icons/. There are more than 5,000 icons.
(#12036, #12170, #12111, #12225)

I fear we can't really do better than that.

@oliviertassinari
Copy link
Member

Module not found: Can't resolve '@material-ui/core/SvgIcon' in 'C:\Users\alexa\node_modules\@material-ui\icons\utils'

This looks like a caching issue.

@barbalex
Copy link
Author

barbalex commented Jul 24, 2018

Actually it seems that basic functionality is breaking as the full error message is:

../node_modules/@material-ui/icons/utils/createSvgIcon.js
Module not found: Can't resolve '@material-ui/core/SvgIcon' in 'C:\Users\alexa\node_modules\@material-ui\icons\utils'

It does not seem to be a missing icon that creates this problem. Or am I missing something?

I tried using the codesandbox.io template but got a different error:

Could not fetch dependencies, please try again in a couple seconds: Could not fetch version for material-ui/icons@latest: ENOENT: no such file or directory, open '/var/task/material-ui/icons@latest/package.json'

See here: https://codesandbox.io/s/py39j89m67

Where is that helpful sentence you quoted? I searched for releases, a changelog file or a mention in the readme file before updating. But found nothing.

@barbalex
Copy link
Author

I ran:

del yarn.lock
rmdir /s node_modules
yarn cache clean

... and still get the error.

I am on Windows 10.

@mbrookes
Copy link
Member

Your example is working fine when you remove the icons v1.x dependency:

https://codesandbox.io/s/xj2qxoxqjz

image

@barbalex
Copy link
Author

Oops. You're right. Sorry for not noticing there was that dependency. Seems like I do something in my app that does not happen in the code sandbox example and that works with v1.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting for author Issue with insufficient information
Projects
None yet
Development

No branches or pull requests

3 participants