Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SpeedDial] Default prop value for "direction" property is wrong #12490

Closed
2 tasks done
brianchirls opened this issue Aug 12, 2018 · 1 comment
Closed
2 tasks done

[SpeedDial] Default prop value for "direction" property is wrong #12490

brianchirls opened this issue Aug 12, 2018 · 1 comment
Labels
component: speed dial This is the name of the generic UI component, not the React module!

Comments

@brianchirls
Copy link

Another PropTypes warning, introduced in v1.5.0.

Forgive me for not filling out the whole form, since this is an extremely straightforward bug. The problem is here:
https://github.com/mui-org/material-ui/blob/master/packages/material-ui-lab/src/SpeedDial/SpeedDial.js#L306

Acceptable values for direction are: ['up', 'down', 'left', 'right'] but the default value is "top".

  • This is a v1.x issue.
  • I have searched the issues of this repository and believe that this is not a duplicate.
@oliviertassinari oliviertassinari added the package: lab Specific to @mui/lab label Aug 13, 2018
@brianchirls
Copy link
Author

Fixed by #12533

@oliviertassinari oliviertassinari changed the title SpeedDial: Default prop value for "direction" property is wrong [SpeedDial] Default prop value for "direction" property is wrong Jan 9, 2021
@oliviertassinari oliviertassinari added component: speed dial This is the name of the generic UI component, not the React module! and removed package: lab Specific to @mui/lab labels Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: speed dial This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brianchirls @oliviertassinari