Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextField] Support different sizes #14521

Closed
fzaninotto opened this issue Feb 13, 2019 · 4 comments · Fixed by #16671
Closed

[TextField] Support different sizes #14521

fzaninotto opened this issue Feb 13, 2019 · 4 comments · Fixed by #16671
Labels
design: material This is about Material Design, please involve a visual or UX designer in the process new feature New feature or request priority: important This change can make a difference

Comments

@fzaninotto
Copy link
Contributor

fzaninotto commented Feb 13, 2019

We're doing a lot of data-heavy desktop apps with Material Design, and a common complain of our users is the low information density.

Material Design contains density guidelines, which help displaying more data on screen. It's particularly useful on Desktop.

image

image

I haven't found any mention of density in material-ui themes, components, and documentation. Is there a plan to support density in any way?

Edit @eps1lon: Updated broken link

@eps1lon
Copy link
Member

eps1lon commented Feb 13, 2019

There is dense for List.

We should add density to the input components too and a separate section to the docs too.

You can control it per theme by overriding the default props: https://material-ui.com/customization/themes/#properties

@fzaninotto
Copy link
Contributor Author

+1 for dense inputs.

I didn't find a way to make a Table dense, either.

@eps1lon eps1lon added new feature New feature or request design: material This is about Material Design, please involve a visual or UX designer in the process labels Feb 13, 2019
@leMaik
Copy link
Member

leMaik commented Feb 16, 2019

@fzaninotto I like the idea of dense tables a lot. I've been implementing some desktop web apps lately and wonder why I haven't thought of this before. 😅

Table has a padding prop that can be set to dense. This only affects the right margin of table cells (what's the use case for this?). I'd really appreciate a new dense property for Table that makes it actually dense.

@oliviertassinari
Copy link
Member

On a side note, I believe we have replaced the dense boolean property with a size enum on some components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design: material This is about Material Design, please involve a visual or UX designer in the process new feature New feature or request priority: important This change can make a difference
Projects
None yet
4 participants