-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IntelliJ/WebStorm IDE props auto-completion broken in 4.0.0 alpha #14582
Comments
Does it still do that with the added |
No, it will navigate to the core/component/index.d.ts where I think it is supposed to and where it was going in the previous versions. I noticed you added the typescript label and while they indeed are typescript typing files, note that I'm not using typescript in the project, it's just that the IDE uses them for auto-completion. |
I think this is the only actionable fix for us though. Autocompletion is working fine in codesandbox (and probably for any vscode version). It's just that webstorm is not up to date. |
@ssypi This was released with |
Thank you, I will let you know by monday, I’m currently on a vacation trip.
|
For some reason, autocompletion for Button and ButtonBase components doesn't seem to work, but everything else I tried works perfectly such as Typography, Icon, IconButton, Step, StepButton, Divider etc. Button and ButtonBase seem to have slightly different d.ts files compared to some others.
vs
Other than that, this is very good. |
4.11.0 still doesn't have autocomplete for <Box/> like it did in 3.9.2. I also tried 5.0.0-alpha.12 and that does not work. Earlier in the thread it was suggested that "Webstorm is just not up to date". What does that mean specifically? It would be really nice if this worked again. |
I am having this issue right now with mui 5. I am on the latest webstorm version. Tried downgrading to the oldest version Jetbrains Toolbox allowed me to (some 2020 version), but unfortunately had the same issue |
Expected Behavior 🤔
In IntelliJ/Webstorm IDE, when importing component and using it in JSX, prop auto-completion/suggestions and validating should work as it did in previous version 3.9.x.
Current Behavior 😯
No props are suggested or validated.
Steps to Reproduce 🕹
Context 🔦
If I downgrade material-ui/core back to 3.9 version, everything works, but not on 4.0.0-alpha.0.
Your Environment 🌎
Solution?/Thoughts`
I noticed that if I add
"typings": "./index.d.ts",
line to for example core\Button\package.json, it works again just like before.Another thing is that if I try to navigate to the source of the imported components, IDE navigates to the source in the core/esm/Component folder instead of core/Component even though I imported from core/Component. Possibly because of "module": "../esm/Chip/index.js", in the Component's package.json. But this is also fixed with the above typings addition.
(Possibly related to issue #14392 )
The text was updated successfully, but these errors were encountered: