Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tooltip] Trigger "Click" should support ESC key to close tooltip #17279

Closed
2 tasks done
MarcusMorba opened this issue Sep 2, 2019 · 2 comments · Fixed by #22376
Closed
2 tasks done

[Tooltip] Trigger "Click" should support ESC key to close tooltip #17279

MarcusMorba opened this issue Sep 2, 2019 · 2 comments · Fixed by #22376
Labels
accessibility a11y component: tooltip This is the name of the generic UI component, not the React module!

Comments

@MarcusMorba
Copy link

Tooltip Trigger "Click" should support ESC key to close tooltip

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

Return (=mouse click) opens the tooltip but if the focus is moved to the next element the tooltip stays while a mouse click somewhere else closes the tooltip.

Expected Behavior 🤔

Pressing ESC should close the tooltip.
@oliviertassinari oliviertassinari added the out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) label Sep 2, 2019
@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 2, 2019 •
edited
Loading

Why?

@erangatl
Copy link

This is a WCAG accessibility Requirement. It would be great to have it inbuilt.

SCR39

@oliviertassinari oliviertassinari added component: tooltip This is the name of the generic UI component, not the React module! and removed out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) labels May 29, 2020
@eps1lon eps1lon reopened this May 29, 2020
@oliviertassinari oliviertassinari mentioned this issue Jun 2, 2020
Merged
@eps1lon eps1lon added accessibility a11y component: snackbar This is the name of the generic UI component, not the React module! and removed component: snackbar This is the name of the generic UI component, not the React module! labels Aug 21, 2020
@eps1lon eps1lon mentioned this issue Aug 21, 2020
Closed
2 tasks
@oliviertassinari oliviertassinari changed the title Tooltip Trigger "Click" should support ESC key to close tooltip [Tooltip] Trigger "Click" should support ESC key to close tooltip Aug 22, 2020
This was referenced Aug 23, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility a11y component: tooltip This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Tooltip] Meet dismissable WCAG criterion eps1lon/material-ui
4 participants
@oliviertassinari @eps1lon @erangatl @MarcusMorba