Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatePicker textfiled value should follow ISO 8601 by default #1839

Closed
mbrookes opened this issue Oct 8, 2015 · 2 comments · Fixed by #3417
Closed

DatePicker textfiled value should follow ISO 8601 by default #1839

mbrookes opened this issue Oct 8, 2015 · 2 comments · Fixed by #3417
Labels
new feature New feature or request

Comments

@mbrookes
Copy link
Member

mbrookes commented Oct 8, 2015

The US date format is ambiguous for dates with day <=12 && day !== month.

05/02/2016 could be read as either May 2nd, or Feb 5th.

I'm thinking ISO8601 (YYYY-MM-DD) would be a good default as it works everywhere, and doesn't have the localisation issues that moving to a short-month-name default (e.g. "2 May 2016") would bring.

Admittedly most users will want to change the date format through the provided hook, but a sensible default would be... sensible.

Happy to create a PR.

@oliviertassinari
Copy link
Member

We have also started a discussion linked to it here #1658 (comment)

@mbrookes
Copy link
Member Author

mbrookes commented Oct 8, 2015

I saw that issue, but it was primarily about full i18n. This would be more of a quick fix for the default date format.

It needs to be fixed regardless of what approach is chosen for i18n, as there will always be a default, so it might as well be a sensible one.

@alitaheri alitaheri added the new feature New feature or request label Dec 9, 2015
@mbrookes mbrookes changed the title DatePicker shouldn't use DD/MM/YYYY by default. DatePicker textfiled value should follow ISO8601 be default Jan 19, 2016
@mbrookes mbrookes changed the title DatePicker textfiled value should follow ISO8601 be default DatePicker textfiled value should follow ISO8601 by default Jan 19, 2016
@mbrookes mbrookes added this to the 0.15.0 Release milestone Feb 2, 2016
@mbrookes mbrookes changed the title DatePicker textfiled value should follow ISO8601 by default DatePicker textfiled value should follow ISO 8601 by default Feb 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants