Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.9.3] Core compilation breaks in Typescript 3.7.2 #18601

Closed
bentona opened this issue Nov 27, 2019 · 3 comments
Closed

[3.9.3] Core compilation breaks in Typescript 3.7.2 #18601

bentona opened this issue Nov 27, 2019 · 3 comments

Comments

@bentona
Copy link

bentona commented Nov 27, 2019

node_modules/@material-ui/core/Portal/Portal.d.ts:2:10 - error TS2440: Import declaration conflicts with local declaration of 'PortalProps'.

2 import { PortalProps } from '../Portal';
           ~~~~~~~~~~~

Found 1 error.

There was a fixed pushed for 4.x here:
#18213
#17676 (comment)

Can we backport this to 3.9?

@oliviertassinari
Copy link
Member

@bentona Do you want to submit a pull request?

@bentona
Copy link
Author

bentona commented Nov 27, 2019

@oliviertassinari Just opened the above.

Thank you for the quick reply!

@oliviertassinari
Copy link
Member

It's the second time I see this request, I was about to ignore it, but this has to count for something https://opencollective.com/clearbit 🤗🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants