-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MenuItem right icons are not styleable if desktop=false #2566
Labels
bug 🐛
Something doesn't work
Comments
@birnam Thanks for finding this. Do you want to submit a PR to fix it? |
Sure @oliviertassinari I'll get that to you asap |
PR @oliviertassinari : #2589 |
This was referenced May 8, 2020
This was referenced Jul 8, 2020
This was referenced Mar 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://github.com/callemall/material-ui/blob/master/src/menus/menu-item.jsx#L168-L172
In MenuItem when merging styles.rightIconDesktop with rightIcon.props.style, the merge only happens if desktop == true, otherwise it sets it to null. If desktop == false it should at least preserve the style property the developer provided for the rightIcon.
The text was updated successfully, but these errors were encountered: