Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ChipDelete][Joy] Support backspace key press #35188

Closed
2 tasks done
siriwatknp opened this issue Nov 18, 2022 · 1 comment · Fixed by #35412
Closed
2 tasks done

[ChipDelete][Joy] Support backspace key press #35188

siriwatknp opened this issue Nov 18, 2022 · 1 comment · Fixed by #35412
Labels
accessibility a11y component: chip This is the name of the generic UI component, not the React module! new feature New feature or request package: joy-ui Specific to @mui/joy waiting for 👍 Waiting for upvotes

Comments

@siriwatknp
Copy link
Member

siriwatknp commented Nov 18, 2022 •
edited
Loading

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Summary 💡

// click or backspace will call the `onDelete` fn.
<ChipDelete onDelete={() => ...} />

Examples 🌈

No response

Motivation 🔦

Mentioned in #20470 (comment) which makes sense to me in terms of accessibility. The component is specific to the delete action, so it should work with the backspace.
@siriwatknp siriwatknp added status: waiting for maintainer These issues haven't been looked at yet by a maintainer new feature New feature or request component: chip This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy waiting for 👍 Waiting for upvotes and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Nov 18, 2022
@hbjORbj
Copy link
Member

hbjORbj commented Dec 8, 2022

I agree that it's a good a11y improvement.

@hbjORbj hbjORbj added the accessibility a11y label Dec 8, 2022
@sai6855 sai6855 mentioned this issue Dec 9, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility a11y component: chip This is the name of the generic UI component, not the React module! new feature New feature or request package: joy-ui Specific to @mui/joy waiting for 👍 Waiting for upvotes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ChipDelete][joy] Add onDelete prop to ChipDelete sai6855/material-ui
2 participants
@siriwatknp @hbjORbj