Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoComplete/Popover] Issues with event bubbling, and openOnFocus doesn't work #3658

Closed
ffxsam opened this issue Mar 10, 2016 · 7 comments · Fixed by #3669
Closed

[AutoComplete/Popover] Issues with event bubbling, and openOnFocus doesn't work #3658

ffxsam opened this issue Mar 10, 2016 · 7 comments · Fixed by #3669
Labels
duplicate This issue or pull request already exists

Comments

@ffxsam
Copy link
Contributor

ffxsam commented Mar 10, 2016

Problem Description

https://github.com/ffxsam/autocomplete-bug

There are multiple issues:

  1. openOnFocus does not work (clicking in the field has no effect)
  2. When typing 'a' and clicking on an item that is outside the dialog, the event bubbles up and causes the dialog to close

Repo install instructions: (or just copy into a webpack boilerplate)

  1. npm install
  2. Install Meteor if not already installed (curl https://install.meteor.com/ | sh).
  3. meteor

Versions

  • Material-UI: 0.15.0-alpha.1
  • React: 0.14.7
  • Browser: Chrome 49
@ffxsam
Copy link
Contributor Author

ffxsam commented Mar 10, 2016

Also: clicking an item from the list doesn't populate the field. I went back and tested 0.14.4. Clicking an item populates the field, however, triggerUpdateOnFocus doesn't seem to work for me.

@bencallaway
Copy link

@ffxsam I'm having similar issues with openOnFocus and triggerUpdateOnFocus with 0.15.0-alpha.1 and 0.14.4, respectively. Your problem may be related to #3381.

@oliviertassinari
Copy link
Member

I think that it's a duplicate of #3381 and #3566.
Can you have a look at #3669 and see if it solve your issues?

@oliviertassinari oliviertassinari added the duplicate This issue or pull request already exists label Mar 12, 2016
@ffxsam
Copy link
Contributor Author

ffxsam commented Mar 30, 2016

@oliviertassinari I've pulled down the latest master branch, and openOnFocus still doesn't work.

@oliviertassinari
Copy link
Member

@ffxsam Could you be more specific? I have noticed an issue where the Popover doesn't close is this the same issue?

@ffxsam
Copy link
Contributor Author

ffxsam commented Mar 31, 2016

What kinds of details would help? Here's the actual code:

        <AutoComplete
          name="tagInput"
          ref="input"
          underlineShow={false}
          dataSource={data}
          openOnFocus={true}
          searchText={this.state.searchText}
          onNewRequest={this.chooseTag}
          onUpdateInput={this.updateInput}
          onKeyPress={this.keyPress}
        />

And clicking in the AutoComplete does not pop up the menu.

@nathanmarks
Copy link
Member

@oliviertassinari @ffxsam

I encountered a bug here too: #3854

I also linked the commit that I think caused it -- I rolled back to the commit prior to it and it seemed to work fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants