Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Grid] Make use of CSS grid #40102

Closed
2 tasks done
mwskwong opened this issue Dec 5, 2023 · 1 comment
Closed
2 tasks done

[Grid] Make use of CSS grid #40102

mwskwong opened this issue Dec 5, 2023 · 1 comment
Labels
component: Grid The React component. duplicate This issue or pull request already exists package: material-ui Specific to @mui/material

Comments

@mwskwong
Copy link
Contributor

mwskwong commented Dec 5, 2023

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Summary 💡

Currently, Grid is using flex layout under the hood. This unfortunately seems to make its implementation more complicated than it needs to be and have more gotcha moments to take note of, e.g. the negative margin. I would like to propose to make use of display: grid instead.

Examples 🌈

No response

Motivation 🔦

No response
@mwskwong mwskwong added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 5, 2023
@danilo-leal danilo-leal added duplicate This issue or pull request already exists component: Grid The React component. package: material-ui Specific to @mui/material and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Dec 5, 2023
@danilo-leal danilo-leal changed the title Make use of CSS grid in Grid [Grid] Make use of CSS grid Dec 5, 2023
@danilo-leal
Copy link
Contributor

Closing this one as it's a duplicate of #9513

@danilo-leal danilo-leal closed this as not planned Won't fix, can't repro, duplicate, stale Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: Grid The React component. duplicate This issue or pull request already exists package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mwskwong @danilo-leal