Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Button] Update the implementation to match the specification when outlined #9526

Closed
1 task done
oliviertassinari opened this issue Dec 17, 2017 · 4 comments
Closed
1 task done
Assignees
Labels
component: button This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process
Milestone

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Dec 17, 2017

  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

We match the specification. It could also be the opportunity to make the implementation more customizable friendly.
https://material.io/guidelines/components/buttons.html#buttons-flat-buttons

dec -03-2017 12-09-27

Current Behavior

We don't follow the spec.

dec -03-2017 12-10-39

Steps to Reproduce (for bugs)

  1. Click on a button and compare the result with the specification.

Context

material-web-components seems to implement the animation correctly. cc @kof

Closes #7537

Your Environment

Tech Version
material-ui v1.0.0-beta.24
react v16.2.0
@oliviertassinari oliviertassinari added component: button This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process labels Dec 17, 2017
@pajaydev
Copy link
Contributor

we should not have the ripple effect on the flat buttons. Correct me if I am wrong.
Can you help me making this change?. @oliviertassinari

@oliviertassinari oliviertassinari added this to the v1.0.0 milestone Jan 16, 2018
@oliviertassinari oliviertassinari modified the milestones: v1.0.0, v1.0.0-prerelease Feb 1, 2018
@sebald
Copy link
Member

sebald commented Feb 1, 2018

@Ajay2507 They have it on their official components: https://material-components-web.appspot.com/button.html

@mbrookes
Copy link
Member

mbrookes commented Feb 1, 2018

Not sure where the "Expected Behavior" gif originates, but the spec shows a ripple: https://material.io/guidelines/components/buttons.html#buttons-flat-buttons (scroll to behavior).

@eps1lon
Copy link
Member

eps1lon commented Mar 5, 2019

Could only detect differences in the border color for outlined buttons (they don't seem to depend on the color variant). This should probably be tackled once states are properly implemented. They're currently not consistent.

@eps1lon eps1lon changed the title [Button] Update the implementation to match the specification [Button] Update the implementation to match the specification when outlined Apr 7, 2019
@eps1lon eps1lon assigned eps1lon and unassigned nathanmarks Apr 7, 2019
@eps1lon eps1lon closed this as completed Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: button This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants