Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Next] Deploy to now with one click deployment fails #9777

Closed
1 task done
sambhav-gore opened this issue Jan 7, 2018 · 2 comments
Closed
1 task done

[Next] Deploy to now with one click deployment fails #9777

sambhav-gore opened this issue Jan 7, 2018 · 2 comments
Labels
docs Improvements or additions to the documentation good first issue Great for first contributions. Enable to learn the contribution process.

Comments

@sambhav-gore
Copy link
Contributor

sambhav-gore commented Jan 7, 2018

  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

One click deployment from https://github.com/mui-org/material-ui/tree/v1-beta/examples/nextjs should work.

Current Behavior

One click deployment to now fails.

Steps to Reproduce (for bugs)

  1. Click on 'deploy to now' button in https://github.com/mui-org/material-ui/tree/v1-beta/examples/nextjs
  2. Provide valid zeit token
  3. Click Deploy
  4. Deployment fails and following message is shown in the deploy page:
Deploying examples/nextjs directory in v1-beta branch of mui-org/material-ui

Deploy failed, please check the repo and try again.

Context

Unable to use one-click deploy to quickly see a demo of this example.

Your Environment

Tech Version
Material-UI
React
browser
etc
@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 7, 2018

I confirm, and there is no error message. The simplest solution is to remove the Deploy to now link.

@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 7, 2018

I have really no clue why it doesn't work. I have tried different alternatives, changing the name of the package, removing the private flag. Nothing help. It's working for this repository, I can't spot the difference: https://github.com/zeit/next.js/tree/canary/examples/custom-server-express.

Let's remove the link. Also, this is promotion we don't receive money for. One more reason to remove the link. I would personally be encouraging people using Firebase instead of now. But again, I don't think that we should be biased on the deploy solution people are using.

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation good first issue Great for first contributions. Enable to learn the contribution process. labels Jan 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation good first issue Great for first contributions. Enable to learn the contribution process.
Projects
None yet
Development

No branches or pull requests

2 participants