From 069275a5209c368016baa2cccec0877aa78afe91 Mon Sep 17 00:00:00 2001 From: PolGuixe Date: Fri, 10 Aug 2018 12:42:43 +0200 Subject: [PATCH 1/3] Update icons.md --- docs/src/pages/style/icons/icons.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/docs/src/pages/style/icons/icons.md b/docs/src/pages/style/icons/icons.md index 2f45602d04daae..95ecb7c88a0348 100644 --- a/docs/src/pages/style/icons/icons.md +++ b/docs/src/pages/style/icons/icons.md @@ -107,3 +107,10 @@ Optionally, you can set the icon color using one of the theme color properties: ### [Font Awesome](https://fontawesome.com/icons) {{"demo": "pages/style/icons/FontAwesome.js", "hideEditButton": true}} + +## Which approach to use? + +Both approaches work fine, however, there are some subtle differences. Especially in terms of performance and rendering quality. +Whenever possible SVG is preferred as it renders faster, better, and allows code splitting. + +For more details, you can check why Github changed from font icons to SVG icons [here](https://blog.github.com/2016-02-22-delivering-octicons-with-svg/). From 83b22faa227e8d911f60f17ef25d31a7a7d3c873 Mon Sep 17 00:00:00 2001 From: Olivier Tassinari Date: Sat, 11 Aug 2018 01:45:16 +0200 Subject: [PATCH 2/3] all good for me --- docs/src/pages/style/icons/icons.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/src/pages/style/icons/icons.md b/docs/src/pages/style/icons/icons.md index 95ecb7c88a0348..9ddd2a6ffdbb4e 100644 --- a/docs/src/pages/style/icons/icons.md +++ b/docs/src/pages/style/icons/icons.md @@ -108,9 +108,9 @@ Optionally, you can set the icon color using one of the theme color properties: {{"demo": "pages/style/icons/FontAwesome.js", "hideEditButton": true}} -## Which approach to use? +## Font vs SVG. Which approach to use? -Both approaches work fine, however, there are some subtle differences. Especially in terms of performance and rendering quality. -Whenever possible SVG is preferred as it renders faster, better, and allows code splitting. +Both approaches work fine, however, there are some subtle differences, especially in terms of performance and rendering quality. +Whenever possible SVG is preferred as it allows code splitting, supports more icons, renders faster and better. -For more details, you can check why Github changed from font icons to SVG icons [here](https://blog.github.com/2016-02-22-delivering-octicons-with-svg/). +For more details, you can check out [why GiHub migrated](https://blog.github.com/2016-02-22-delivering-octicons-with-svg/) from font icons to SVG icons. From 833b5b06bc96e0a5c3e2c5527ecb96e23afb096d Mon Sep 17 00:00:00 2001 From: PolGuixe Date: Tue, 14 Aug 2018 10:51:13 +0200 Subject: [PATCH 3/3] fixed typo --- docs/src/pages/style/icons/icons.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/src/pages/style/icons/icons.md b/docs/src/pages/style/icons/icons.md index 9ddd2a6ffdbb4e..84eb3637ad2ba7 100644 --- a/docs/src/pages/style/icons/icons.md +++ b/docs/src/pages/style/icons/icons.md @@ -113,4 +113,4 @@ Optionally, you can set the icon color using one of the theme color properties: Both approaches work fine, however, there are some subtle differences, especially in terms of performance and rendering quality. Whenever possible SVG is preferred as it allows code splitting, supports more icons, renders faster and better. -For more details, you can check out [why GiHub migrated](https://blog.github.com/2016-02-22-delivering-octicons-with-svg/) from font icons to SVG icons. +For more details, you can check out [why GitHub migrated](https://blog.github.com/2016-02-22-delivering-octicons-with-svg/) from font icons to SVG icons.