Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update CHANGELOG.md #14516

Merged
merged 2 commits into from
Feb 13, 2019
Merged

[docs] Update CHANGELOG.md #14516

merged 2 commits into from
Feb 13, 2019

Conversation

hexetia
Copy link
Contributor

@hexetia hexetia commented Feb 13, 2019

There is a small error in the file, where the removed button property in v4 was 'raised' and not 'contained'

@mbrookes
Copy link
Member

Good catch. While we're here, would you mind please also changing the first sentence:

-This is our first unstable release towards Material-UI v4.0.0.
+This is our first unstable release toward Material-UI v4.0.0.

(American English...)

@hexetia
Copy link
Contributor Author

hexetia commented Feb 13, 2019

when this pull was merged, the release changelog page will change too?

https://github.com/mui-org/material-ui/releases/tag/v4.0.0-alpha.0

because the 'raised' 'contained' mistake it's there too

@mbrookes
Copy link
Member

@saculbr I've fixed it there. (I had already reversed my incorrect change of toward / towards.)

@oliviertassinari oliviertassinari changed the title Update CHANGELOG.md [docs] Update CHANGELOG.md Feb 13, 2019
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Feb 13, 2019
@oliviertassinari oliviertassinari merged commit 05875b2 into mui:next Feb 13, 2019
@oliviertassinari
Copy link
Member

Thank you guys! 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants