Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sync] Plugin generates an incorrect theme object shape that's not compatible with createTheme(...) #432

Open
SaavanFreed opened this issue Dec 12, 2024 · 0 comments
Labels
bug 🐛 Something doesn't work figma scope: sync Issues related to the Material UI Sync Figma plugin

Comments

@SaavanFreed
Copy link

SaavanFreed commented Dec 12, 2024

Steps to reproduce

Steps:

  1. Download SampleTheme.json
  2. Run createTheme(sampleThemeJson); in a basic project
  3. Verify the theme is not actually being applied

Current behavior

It uses the default theme object instead of the one generated by the plugin.

Expected behavior

  1. It should use the theme object I'm supplying or at the very least throw an error if it's not going to use it.
  2. The shape of the object generated by the plugin should match the TypeScript type for the MUI Theme object.

Context

I want to create a theme, export it using the Sync Plugin, and import it into my MUI app.

Your environment

Software Version
Design file version v5.?.?
Design tool Figma/Adobe XD/Sketch
etc.

Search keywords: MUI Sync Plugin, Design Kit

@SaavanFreed SaavanFreed added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 12, 2024
@SaavanFreed SaavanFreed changed the title MUI Sync Plugin is generating a weird theme object shape that's not compatible with MUI TypeScript Sync Plugin generates an incorrect theme object shape that's not compatible with createTheme(...) Dec 12, 2024
@zannager zannager added figma scope: sync Issues related to the Material UI Sync Figma plugin labels Dec 13, 2024
@oliviertassinari oliviertassinari changed the title Sync Plugin generates an incorrect theme object shape that's not compatible with createTheme(...) [sync] Plugin generates an incorrect theme object shape that's not compatible with createTheme(...) Dec 22, 2024
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work figma scope: sync Issues related to the Material UI Sync Figma plugin
Projects
None yet
Development

No branches or pull requests

4 participants