Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Remove MarkdownElement import #3451

Merged
merged 3 commits into from
Apr 25, 2024
Merged

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Apr 24, 2024

Fixes #3442

Also fixes the scroll bar under the tab container, and clips the rounded corners correctly

Remove MarkdownElement import from src/components/markdown/MarkdownElement
See mui/material-ui#41859 (comment)

Aside, HighlightedCode is a bit hard to use imo.

Intuitively I'd expect three levels of abstraction here, so that I can mix and match to my use case.

  1. a highlighted code block, which auto sizes with the height, no border/corners
  2. a code viewport, which provides the scroll behavior
  3. a container which provides title/tabs and clips the corners

Preview: https://deploy-preview-3451--mui-toolpad-docs.netlify.app/toolpad/

before:

Screenshot 2024-04-24 at 16 32 32

after:

Screenshot 2024-04-24 at 16 32 39

@Janpot Janpot added the docs Improvements or additions to the documentation label Apr 24, 2024
@Janpot Janpot changed the title Remove MarkdownElement import [docs] Remove MarkdownElement import Apr 24, 2024
@Janpot Janpot marked this pull request as ready for review April 24, 2024 14:56
@Janpot Janpot merged commit a49d575 into mui:master Apr 25, 2024
12 checks passed
@Janpot Janpot deleted the remove-md-elm branch April 25, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] code example background problem
2 participants