Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate build and test configuration #418

Open
matthew-brett opened this issue Jul 13, 2021 · 1 comment
Open

Separate build and test configuration #418

matthew-brett opened this issue Jul 13, 2021 · 1 comment

Comments

@matthew-brett
Copy link
Collaborator

#417 has brought up a subject we haven't resolved, which is how to separate build and test configurations.

At the moment, Mac doesn't distinguish; we source the files named in ENV_VARS_PATH and CONFIG_PATH, and both build and test run with those configurations.

Manylinux does distinguish, in that a) we don't pass, or source ENV_VARS_PATH in the test phase, and b) the user could, if they wanted, change CONFIG_PATH before the test phase, to get a different test configuration.

Two questions for the company:

  • Should we, in fact, pass and source ENV_VARS_PATH in the Manylinux test phase? This would be a back-compatibility break, but it seems reasonable given we effectively have that behavior on Mac already.
  • Should we add a new function called something like init_test_phase, which could switch any configurations. In that function we could:
    • Set an environment variable MB_PHASE to 'test, for use by conditionals in config.sh and similar.
    • Switch CONFIG_PATH and ENV_VARS_PATH to (if present) new environment variables TEST_CONFIG_PATH and TEST_ENV_VARS_PATH.

What do y'all think?

@mattip
Copy link
Collaborator

mattip commented Aug 10, 2021

I think these days we should encourage testing outside of multibuild. The point of multibuild is to build wheels, there should be an option to leave testing outside the scope of multibuild. Many CI platforms are better than we can be about getting newer versions of OS and Python out to users. Github actions has nightly builds of CPython and PyPy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants