Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_modern_cmake - version 3? #439

Open
snowman2 opened this issue Nov 3, 2021 · 1 comment
Open

get_modern_cmake - version 3? #439

snowman2 opened this issue Nov 3, 2021 · 1 comment

Comments

@snowman2
Copy link
Contributor

snowman2 commented Nov 3, 2021

Currently it attempts to get 28, but the default cmake version is 3.21.3.

if [ "`yum search cmake | grep ^cmake28\.`" ]; then
cmake=cmake28
fi

$ docker run --rm -it --entrypoint bash --network host quay.io/pypa/manylinux2010_i686:latest
# yum search cmake | grep ^cmake
cmake-fedora.noarch : CMake helper modules for fedora developers
cmake-gui.i686 : Qt GUI for cmake
cmake28-gui.i686 : Qt GUI for cmake28
cmake3-data.noarch : Common data-files for cmake3
cmake3-doc.noarch : Documentation for cmake3
cmake3-gui.i686 : Qt GUI for cmake3
cmake.i686 : Cross-platform make system
cmake28.i686 : Cross-platform make system
cmake3.i686 : Cross-platform make system
# cmake --version
cmake version 3.21.3

Is there a reason not to use version 3?

@mattip
Copy link
Collaborator

mattip commented Oct 23, 2024

I think that stanza is really outdated. We can just remove it. The function also does not check if cmake is currently installed already, as it is in most current CI images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants