-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error: 12.1.2 Causes node issue when implementing Helia #154
Comments
Can you update to LTS node? We only run CI on LTS so there's no guarantee anything will work on maintenance or other legacy versions. |
Hey @achingbrain we have some other dependencies that unfortunately only work with node 16 atm. Would it be possible to instead bump the major version for this package with this node upgrade instead, for example instead of 12.1.2 a change to 13? (and the corresponding libraries @libp2p/bootstrap, @libp2p/websockets, libp2p can also update their package set)This way it would prevent rolling breaking changes across other apps that could depend on a specific node version. Since this change is a breaking change it seems based on semantic versioning this should be a major change (aka 13 instead of a patch fix based on https://docs.npmjs.com/about-semantic-versioning) |
@achingbrain: (inexperienced here on the tooling) will ipfs/aegir#1276 address this? |
#155 will fix it, ipfs/aegir#1276 / ipfs/aegir#1277 will prevent it from recurring in future. |
@Faolain out of interest what are they? Node 16 is EOL in September so it'd be good to know what people are still using. |
🎉 This issue has been resolved in version 12.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
error @multiformats/mafmt@12.1.2: The engine "node" is incompatible with this module. Expected version ">=18.0.0". Got "16.16.0"
This latest
12.1.2
change causes issues with node version16.16
.This is due to dependencies here
@libp2p/bootstrap@^6.0.3
@libp2p/websockets@^5.0.10
libp2p@^0.44.0
They all have
"@multiformats/mafmt" "^12.0.0"
because of this they try to install12.1.2
which breaks with older node version and I am unable to use a prior version due to this settingThe text was updated successfully, but these errors were encountered: