Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: 12.1.2 Causes node issue when implementing Helia #154

Closed
TheGreatAlgo opened this issue May 15, 2023 · 6 comments · Fixed by #155
Closed

Error: 12.1.2 Causes node issue when implementing Helia #154

TheGreatAlgo opened this issue May 15, 2023 · 6 comments · Fixed by #155
Labels

Comments

@TheGreatAlgo
Copy link

TheGreatAlgo commented May 15, 2023

error @multiformats/mafmt@12.1.2: The engine "node" is incompatible with this module. Expected version ">=18.0.0". Got "16.16.0"
This latest 12.1.2 change causes issues with node version 16.16.

This is due to dependencies here

@libp2p/bootstrap@^6.0.3
@libp2p/websockets@^5.0.10
libp2p@^0.44.0

They all have "@multiformats/mafmt" "^12.0.0" because of this they try to install 12.1.2 which breaks with older node version and I am unable to use a prior version due to this setting

image

@achingbrain
Copy link
Member

Can you update to LTS node? We only run CI on LTS so there's no guarantee anything will work on maintenance or other legacy versions.

@Faolain
Copy link

Faolain commented May 16, 2023

Hey @achingbrain we have some other dependencies that unfortunately only work with node 16 atm. Would it be possible to instead bump the major version for this package with this node upgrade instead, for example instead of 12.1.2 a change to 13? (and the corresponding libraries @libp2p/bootstrap, @libp2p/websockets, libp2p can also update their package set)This way it would prevent rolling breaking changes across other apps that could depend on a specific node version.

Since this change is a breaking change it seems based on semantic versioning this should be a major change (aka 13 instead of a patch fix based on https://docs.npmjs.com/about-semantic-versioning)

Screenshot 2023-05-16 at 2 23 53 PM

@BigLep
Copy link

BigLep commented May 16, 2023

@achingbrain: (inexperienced here on the tooling) will ipfs/aegir#1276 address this?

@achingbrain
Copy link
Member

#155 will fix it, ipfs/aegir#1276 / ipfs/aegir#1277 will prevent it from recurring in future.

@achingbrain
Copy link
Member

we have some other dependencies that unfortunately only work with node 16 atm

@Faolain out of interest what are they? Node 16 is EOL in September so it'd be good to know what people are still using.

@github-actions
Copy link

🎉 This issue has been resolved in version 12.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants