Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typings and add type test #112

Merged
merged 2 commits into from
Feb 28, 2020
Merged

Conversation

robertkiel
Copy link

This fixes some issues with typings and adds a test that checks whether we export the types correctly.

It also includes all installed @types/... types instead of having a manual configuration. See https://www.typescriptlang.org/docs/handbook/tsconfig-json.html#types-typeroots-and-types for more information.

@jacobheun
Copy link
Contributor

@wemeetagain @carsonfarmer mind checking out the types updates here?

I'm not sure if these are breaking type changes or not. If so, I may move these to a future v8 branch, as I'd prefer to avoid a major release that only includes type updates.

@robertkiel
Copy link
Author

Exactly, these changes are "only" type upgrades ... And some @ts-ignore in the test file such that Typescript does not break up the type check process.

It also adds a check to .fromNodeAddress(obj) that restricts family to IPv4 and IPv6.

Before, you could set IPv6 or anything else

@carsonfarmer
Copy link

Most of these changes are aesthetic (though useful/good). There doesn't appear to be any type breakage just type upgrades as @robertkiel has specified. Probably safe to merge, but no need for a major release, minor would be fine.

@wemeetagain
Copy link
Contributor

LGTM agreed with @carsonfarmer and @robertkiel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants