New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only compute path on first getPath() call #318

Merged

achingbrain merged 1 commit into multiformats:master from twoeths:tuyen/get_path

Apr 14, 2023

Contributor

twoeths commented Apr 12, 2023

Motivation

getPath() is not cheap so we want to only compute it on first call. See fix: avoid Multiaddr.getPath() performance issue libp2p/js-libp2p-tcp#264 (comment)

Description

Add private field #path and cache it on the first getPath() call


          feat: only compute path on first getPath() call

f307c11

twoeths mentioned this pull request

fix: avoid Multiaddr.getPath() performance issue libp2p/js-libp2p-tcp#264

Closed

achingbrain changed the title ~~feat: only compute path on first getPath() call~~ fix: only compute path on first getPath() call

achingbrain approved these changes

View reviewed changes

achingbrain merged commit 9fd631f into multiformats:master

github-actions bot pushed a commit that referenced this pull request


          chore(release): 12.1.2 [skip ci]

8582c09

## [12.1.2](v12.1.1...v12.1.2) (2023-04-14)

### Bug Fixes

* only compute path on first getPath() call ([#318](#318)) ([9fd631f](9fd631f)), closes [/github.com/libp2p/js-libp2p-tcp/pull/264#issuecomment-1503473722](https://github.com/multiformats//github.com/libp2p/js-libp2p-tcp/pull/264/issues/issuecomment-1503473722)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet