Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce setting "sender" (instead of emitting a console WARN) #291

Closed
andreibancioiu opened this issue Apr 12, 2023 · 1 comment
Closed

Enforce setting "sender" (instead of emitting a console WARN) #291

andreibancioiu opened this issue Apr 12, 2023 · 1 comment
Assignees
@andreibancioiu
Labels
task Task

Comments

@andreibancioiu
Copy link
Contributor

andreibancioiu commented Apr 12, 2023 •
edited
Loading

@andreibancioiu andreibancioiu added the task Task label Apr 12, 2023
@andreibancioiu andreibancioiu self-assigned this Apr 12, 2023
@andreibancioiu
Copy link
Contributor Author

For legacy approaches of constructing transactions, we will still be emitting WARNs, instead of throwing errors:

However, the new transaction factories of v13 do require the sender parameter:

@andreibancioiu andreibancioiu mentioned this issue Apr 8, 2024
Merged
@popenta popenta closed this as completed Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreibancioiu andreibancioiu

Labels
task Task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andreibancioiu @popenta