From 2a6d3144f373de71fc74af67e978a0c7aa495ab4 Mon Sep 17 00:00:00 2001 From: Howard-C Date: Fri, 28 Aug 2020 14:47:17 +0800 Subject: [PATCH] fix #308139: Create Time Signatures dialogue doesn't need to add special text whenever the internal value of nominator or denominator is changed Special texts are useful just because they can be different from the internal values. There's no need of updating them if the internal values are changed, because they are either blank (and are most likely wished to still be blank, because then they won't affect the layout of the internal values for the time signature) or different from the original values (and are most likely wished to still be different, because if not, there's no point of having them). See more in https://musescore.org/node/308139#comment-1022250. --- mscore/timedialog.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/mscore/timedialog.cpp b/mscore/timedialog.cpp index b5b87164d7063..7cd07ea995a3a 100644 --- a/mscore/timedialog.cpp +++ b/mscore/timedialog.cpp @@ -127,7 +127,6 @@ void TimeDialog::save() void TimeDialog::zChanged(int val) { - zText->setText(QString("%1").arg(val)); Fraction sig(zNominal->value(), denominator()); groups->setSig(sig, Groups::endings(sig), zText->text(), nText->text()); } @@ -138,7 +137,6 @@ void TimeDialog::zChanged(int val) void TimeDialog::nChanged(int /*val*/) { - nText->setText(QString("%1").arg(denominator())); Fraction sig(zNominal->value(), denominator()); groups->setSig(sig, Groups::endings(sig), zText->text(), nText->text()); }