{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":178628673,"defaultBranch":"master","name":"gofumpt","ownerLogin":"mvdan","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2019-03-31T01:17:51.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/3576549?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1723846990.0","currentOid":""},"activityList":{"items":[{"before":"45e806f4d0eac8f59836d5850fec6aea4632c077","after":"86bffd62437a3c437c0b84d5d5ab244824e762fc","ref":"refs/heads/master","pushedAt":"2024-08-16T22:19:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"CI: drop Go 1.21, add Go 1.23\n\nForgot to do this in an earlier commit when we started requiring go1.22.","shortMessageHtmlLink":"CI: drop Go 1.21, add Go 1.23"}},{"before":"038012a9487296e45c322882d3412c1f11af036e","after":"45e806f4d0eac8f59836d5850fec6aea4632c077","ref":"refs/heads/master","pushedAt":"2024-08-16T22:15:14.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"add release notes for v0.7.0","shortMessageHtmlLink":"add release notes for v0.7.0"}},{"before":"88a300bbd6dc134f6d532f542297873027e1dc27","after":"038012a9487296e45c322882d3412c1f11af036e","ref":"refs/heads/master","pushedAt":"2024-07-19T14:56:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"update published gofumpt versions in tests\n\nI forgot that I was hard-coding published pseudo-versions of gofumpt,\nand those need to be updated for the new diagnosing and lang version\nlogic to be used.","shortMessageHtmlLink":"update published gofumpt versions in tests"}},{"before":"5aa75463847f5c046c5cab2ae8a70461ebd8ffdd","after":"88a300bbd6dc134f6d532f542297873027e1dc27","ref":"refs/heads/master","pushedAt":"2024-07-19T14:38:34.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"require Go 1.22 and use go/version for Options.LangVersion\n\nThis is a Go API breaking change; where existing users could use\nstrings such as \"1.16\" or \"v1.16\", they should now use \"go1.16\".\nNote that the \"go\" prefix is mandatory, following go/version.\n\nI considered a softer landing to manipulate the older string formats\nto conform to the new format, but given how go/version is strict\nand Go versions are now clearly defined differently from SemVer,\nit seems best to draw a line and follow go/version's notion of validity.\n\nSupporting \"go1.16\" alongside \"v1.16\" could also cause confusion in the\nlong run, as Go versions are subtly different from SemVer in terms\nof validity and order. Requiring the \"go\" prefix avoids footguns.\n\nMost gofumpt CLI users shouldn't be using the -lang CLI flag directly,\nas by default it grabs its value from the go directive in go.mod.\nHence, most gofumpt CLI users should not be affected by this breakage.\nGo API users, such as tool or IDE integration authors, are more likely\nto get broken as the API falls back to assuming a conservative Go 1.0.\nFixing the breakage is rather simple, as shown by the changes below.\n\nWhile here, suggest `go list -m` rather than `go mod edit -json`,\nas the latter requires using `jq` to obtain just one field.\nWe still mention the latter command as an alternative.","shortMessageHtmlLink":"require Go 1.22 and use go/version for Options.LangVersion"}},{"before":"52739c56d0efd3647a627598a55e821324f8571b","after":"5aa75463847f5c046c5cab2ae8a70461ebd8ffdd","ref":"refs/heads/master","pushedAt":"2024-07-13T18:52:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"group internal/... import paths as standard library\n\nThe Go standard library includes internal packages such as\ninternal/testenv, and even though such packages cannot be imported\ndirectly by users, they are still imported by std packages like os\nand should be grouped with the rest of the std packages.\n\nI can't recall what my logic was for excluding internal/ prefixes\nfrom std grouping, but the logic no longer makes any sense to me.\nThis makes gofumpt less grumpy with how Go groups its own std imports.\n\nFixes #307.","shortMessageHtmlLink":"group internal/... import paths as standard library"}},{"before":"636d7a7b9ae6db4704a12cd990b57a7c8f0ede78","after":"52739c56d0efd3647a627598a55e821324f8571b","ref":"refs/heads/master","pushedAt":"2024-02-25T23:20:47.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"swap frankban/quicktest for go-quicktest/qt","shortMessageHtmlLink":"swap frankban/quicktest for go-quicktest/qt"}},{"before":"37e046337216f326d5cd551ea0d12463919c13d0","after":"636d7a7b9ae6db4704a12cd990b57a7c8f0ede78","ref":"refs/heads/master","pushedAt":"2024-01-28T22:36:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"add release notes for v0.6.0","shortMessageHtmlLink":"add release notes for v0.6.0"}},{"before":"ddd4dc460c4eda67953793a69d0caa3512b61609","after":"37e046337216f326d5cd551ea0d12463919c13d0","ref":"refs/heads/master","pushedAt":"2024-01-28T16:16:55.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"format: ignore //line directives when computing positions\n\nOtherwise, if the line directives give us line numbers\nwhich don't make any sense given the real file's line numbers,\nour use of MergeLines can cause a panic or just bad formatting.\n\nFixes #288.","shortMessageHtmlLink":"format: ignore //line directives when computing positions"}},{"before":"5249497a888886f92caeed2f26757c13beea0987","after":"ddd4dc460c4eda67953793a69d0caa3512b61609","ref":"refs/heads/master","pushedAt":"2023-12-27T22:56:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"skip gomod.txtar testscript on Go 1.20\n\nI had forgotten that Go versions before 1.21 cannot parse these files.\nCI with Go 1.20 reminded me.","shortMessageHtmlLink":"skip gomod.txtar testscript on Go 1.20"}},{"before":"13743a4ceea0de3a1e2c33c27805200ce0866962","after":"5249497a888886f92caeed2f26757c13beea0987","ref":"refs/heads/master","pushedAt":"2023-12-27T22:22:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"add package godoc","shortMessageHtmlLink":"add package godoc"}},{"before":"4ac1be2f50416ae71dc4b45b400eff7c11965d51","after":"13743a4ceea0de3a1e2c33c27805200ce0866962","ref":"refs/heads/master","pushedAt":"2023-12-27T22:18:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"format: support Go versions from newer go.mod files\n\nThe 'go' directive in go.mod files can now contain strings such as\n\"go1.22rc1\" or \"go1.21.1\", and our old semver logic didn't support\nsome of those.\n\nUpstream is providing new API via go/version in Go 1.22,\nbut until that is out, we implement our own workaround to avoid panics.\n\nFixes #280.","shortMessageHtmlLink":"format: support Go versions from newer go.mod files"}},{"before":"a8415d36b4f301e30fbf2aec0f5699ccad3d3316","after":"4ac1be2f50416ae71dc4b45b400eff7c11965d51","ref":"refs/heads/master","pushedAt":"2023-10-29T10:24:18.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"Update Helix editor config\n\nHelix editor version 23.10 changes the way language servers are\nconfigured. See https://helix-editor.com/news/release-23-10-highlights.","shortMessageHtmlLink":"Update Helix editor config"}},{"before":"025a91f64d518cb7e1c399428a61685d513c4214","after":"a8415d36b4f301e30fbf2aec0f5699ccad3d3316","ref":"refs/heads/master","pushedAt":"2023-09-25T21:19:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"format: add a TODO to remind myself about token.File.Lines","shortMessageHtmlLink":"format: add a TODO to remind myself about token.File.Lines"}},{"before":"9a108c1953290163d2104befba4a340b5f553001","after":"025a91f64d518cb7e1c399428a61685d513c4214","ref":"refs/heads/master","pushedAt":"2023-08-23T20:19:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"treat err assignments as a simple error check\n\nWe considered the following pattern a \"simple\" error check,\nwhere err was declared with `:=` and immediately followed by an if:\n\n    x, err := f()\n\n    if err != nil {...}\n\nWe would then remove the empty line before the error check.\nHowever, we wouldn't do the same if x and err were already declared:\n\n    x, err = f()\n\n    if err != nil {...}\n\nThe second form is still relatively common, and there's no good reason\nfor the check to treat the two cases differently.\n\nFixes #271.","shortMessageHtmlLink":"treat err assignments as a simple error check"}},{"before":"c3f1926378cb4062c73e2debcdd4667a777c8133","after":null,"ref":"refs/heads/go1.21","pushedAt":"2023-08-23T20:11:21.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"}},{"before":"39163cc6b32cdf077a3cf08a68379851560cf81f","after":"9a108c1953290163d2104befba4a340b5f553001","ref":"refs/heads/master","pushedAt":"2023-08-15T09:57:03.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"add Go 1.21, drop 1.19","shortMessageHtmlLink":"add Go 1.21, drop 1.19"}},{"before":null,"after":"c3f1926378cb4062c73e2debcdd4667a777c8133","ref":"refs/heads/go1.21","pushedAt":"2023-08-15T09:48:49.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"add Go 1.21, drop 1.19","shortMessageHtmlLink":"add Go 1.21, drop 1.19"}},{"before":"ea3d4139c13ad425d654add975cf34b657ed9469","after":"39163cc6b32cdf077a3cf08a68379851560cf81f","ref":"refs/heads/master","pushedAt":"2023-06-10T19:46:10.223Z","pushType":"push","commitsCount":1,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"update deps","shortMessageHtmlLink":"update deps"}},{"before":"36b4fbb15b1a2e154e137d1005b25deccc02d488","after":"ea3d4139c13ad425d654add975cf34b657ed9469","ref":"refs/heads/master","pushedAt":"2023-04-14T17:06:33.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"don't add whitespace to //NOSONAR comments\n\nWhen using sonarqube, `//NOSONAR` can be used to disable\r\nSONAR parsing for this line on false-positives.\r\n\r\nSee: https://docs.sonarcloud.io/appendices/frequently-asked-questions/\r\n\r\nThis only works if there is no space between the slashes and `NOSONAR`.\r\n\r\nCo-authored-by: Kimi Loeffel <kimi.loeffel@bit.admin.ch>","shortMessageHtmlLink":"don't add whitespace to //NOSONAR comments"}},{"before":"fd93f1d8818fc86a956b9706ad8b81734c81cc1e","after":"36b4fbb15b1a2e154e137d1005b25deccc02d488","ref":"refs/heads/master","pushedAt":"2023-04-09T21:02:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"CHANGELOG: fix the v0.5.0 issue links\n\nAlready tagged, but oh well.","shortMessageHtmlLink":"CHANGELOG: fix the v0.5.0 issue links"}},{"before":"e2f1a6edb1c890074eea851e5c2fe032eeaa4a77","after":"fd93f1d8818fc86a956b9706ad8b81734c81cc1e","ref":"refs/heads/master","pushedAt":"2023-04-09T20:59:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"add release notes for v0.5.0","shortMessageHtmlLink":"add release notes for v0.5.0"}},{"before":"48add9081479c38b377461631dbd82ffb8162efe","after":"e2f1a6edb1c890074eea851e5c2fe032eeaa4a77","ref":"refs/heads/master","pushedAt":"2023-04-09T13:55:54.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"skip over testdata dirs like we do with vendor\n\nAnd, just like vendor, one can opt into formatting them by explicitly\npassing them as arguments.\n\nUpdates #250.\nFixes #260.","shortMessageHtmlLink":"skip over testdata dirs like we do with vendor"}},{"before":"8b01b13b2fb53f2d9485268a6e6c2137cbb7e710","after":"48add9081479c38b377461631dbd82ffb8162efe","ref":"refs/heads/master","pushedAt":"2023-04-08T21:45:41.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"add broken test case which reorders and separates imports\n\nWe split into three groups rather than two.\nFixing this right now is tricky, due to go/ast positions.\nHowever, we can add the test case to increase test coverage,\nand to ensure that we don't lose the reproducer.\n\nFor #225.","shortMessageHtmlLink":"add broken test case which reorders and separates imports"}},{"before":"92e2be66b0ad7acd4bcc0e79220d5367c3cfa3fb","after":"8b01b13b2fb53f2d9485268a6e6c2137cbb7e710","ref":"refs/heads/master","pushedAt":"2023-04-08T20:42:26.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"relax rule to insert newlines in func signatures\n\nIn particular, in cases where a field list fits all in one line,\nadding a newline at the end of the field list is clearly wrong.\n\nFixes #235.","shortMessageHtmlLink":"relax rule to insert newlines in func signatures"}},{"before":"04a7ba7e6e8dad6399a97e14248ae3d595b8a9d0","after":"92e2be66b0ad7acd4bcc0e79220d5367c3cfa3fb","ref":"refs/heads/master","pushedAt":"2023-04-08T17:44:46.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"internal/govendor: undo upstream change to use strings.CutPrefix\n\nWe still support Go 1.19, and this API was added in 1.20.","shortMessageHtmlLink":"internal/govendor: undo upstream change to use strings.CutPrefix"}},{"before":"749738aece3469e464d262a2644018fe0ae4abbe","after":"04a7ba7e6e8dad6399a97e14248ae3d595b8a9d0","ref":"refs/heads/master","pushedAt":"2023-04-08T16:13:38.000Z","pushType":"push","commitsCount":9,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"update deps","shortMessageHtmlLink":"update deps"}},{"before":"62ec1a620baca51884e1517e1f33d987dd2e0779","after":null,"ref":"refs/heads/ulimit-unix","pushedAt":"2023-03-22T21:35:28.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"}},{"before":"138ae17e382c6d9a97791e6f3ea2b9c58cc057c8","after":"749738aece3469e464d262a2644018fe0ae4abbe","ref":"refs/heads/master","pushedAt":"2023-03-18T16:02:26.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"settle for only running the ulimit test on linux\n\nI tried using the unix build tag, although predictably,\nthe test is prone to failure on darwin:\n\n\tfork/exec /var/[...]/gofumpt.test: argument list too long\n\nTesting ulimits on one GOOS is enough,\nespecially since we'll always test on linux via CI.","shortMessageHtmlLink":"settle for only running the ulimit test on linux"}},{"before":"e748ceddcafd2036cc3f60138ef653f7d02e1b86","after":"62ec1a620baca51884e1517e1f33d987dd2e0779","ref":"refs/heads/ulimit-unix","pushedAt":"2023-03-18T11:50:24.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"settle for only running the ulimit test on linux\n\nI tried using the unix build tag, although predictably,\nthe test is prone to failure on darwin:\n\n\tfork/exec /var/[...]/gofumpt.test: argument list too long\n\nTesting ulimits on one GOOS is enough,\nespecially since we'll always test on linux via CI.","shortMessageHtmlLink":"settle for only running the ulimit test on linux"}},{"before":null,"after":"e748ceddcafd2036cc3f60138ef653f7d02e1b86","ref":"refs/heads/ulimit-unix","pushedAt":"2023-03-18T11:39:24.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mvdan","name":"Daniel Martí","path":"/mvdan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3576549?s=80&v=4"},"commit":{"message":"use the unix build tag to fix a TODO","shortMessageHtmlLink":"use the unix build tag to fix a TODO"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEnIo1YAA","startCursor":null,"endCursor":null}},"title":"Activity · mvdan/gofumpt"}