Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clipboard monitoring issue #26

Closed
MrPiethon opened this issue Apr 13, 2020 · 8 comments
Closed

Clipboard monitoring issue #26

MrPiethon opened this issue Apr 13, 2020 · 8 comments

Comments

@MrPiethon
Copy link

Hi Ludios,

Thanks for picking up the project, I just wanted to let you know of a small issue with the clipboard monitoring. If we have another program open (JGlossator) that monitors the clipboard, it seems to affect qolibri from monitoring the clipboard.

However, if I were to ctrl + c several times, then it would finally pick up the word and show up in qolibri.

Not the end of the world, but it would be nice to have the clipboard monitoring work on the first try 90%+ of the time.

Environment:
Windows 10 64bit
qolibri (2.1.3, win32)

@mvf
Copy link
Owner

mvf commented Apr 13, 2020

Thanks for reporting this. Turns out it's an issue with the Qt framework qolibri is using (QTBUG-53979). Upon receipt of a WM_CLIPBOARDUPDATE message, Qt will try to retrieve the updated clipboard contents, which can fail if another application has the clipboard locked at the same time. Starting with version 5.14, Qt will retry 3 times with a 50 ms delay, which seems to make it work with JGlossator.

Unfortunately, while testing the 2.1.3 Windows release, I found that with Qt 5.14, after opening a web search, clipboard monitoring stops working completely until the application is restarted. That's why 2.1.3 is built against 5.13 on Windows.

It will take a while to address this issue with Qt upstream. In the meantime I added a Qt 5.14 based build to the 2.1.3 release. As long as you're not using web searches, it might improve your situation.

@MrPiethon
Copy link
Author

Hi Matthias,

Thanks for the speedy response and fix, I did some preliminary testing with both of them open and it seems to work very well. I'll have some more time to actually look into it later today.

As for the issue with web search, it's definitely something I can live without. Thanks so much!

@MrPiethon
Copy link
Author

It's seems like it is working well :)

@mvf
Copy link
Owner

mvf commented Apr 19, 2020

Cheers for the feedback! I updated the 2.1.3 release notes.

@MrPiethon
Copy link
Author

Hi @mvf would you like me to close out the issue or keep it open?

@mvf
Copy link
Owner

mvf commented Apr 30, 2020

Hi @MrPiethon Totally up to you. If this is resolved from your PoV and you want it off your open issues list, feel free to close this issue. I would then open a new one though, since we still need a proper fix.

@MrPiethon
Copy link
Author

No worries, I have no issue with keeping this open until a proper fix is released. I hope you have a wonderful 2021!

@mvf mvf added this to the 2.1.4 milestone Jun 13, 2021
@mvf
Copy link
Owner

mvf commented Jul 4, 2021

2.1.4 will be built against Qt 5.15.2, where all of this is fixed. Thanks for your patience and all the best to you too! 😉

@mvf mvf closed this as completed Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants