Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to Bazel Modules #13

Closed
finn-ball opened this issue Mar 25, 2024 · 4 comments
Closed

Port to Bazel Modules #13

finn-ball opened this issue Mar 25, 2024 · 4 comments

Comments

@finn-ball
Copy link
Contributor

Port the project to bazel modules as defined here:
https://bazel.build/external/module

As of Bazel 7, this is now the default way to bring in dependencies:
https://blog.bazel.build/2023/12/11/bazel-7-release.html

@finn-ball
Copy link
Contributor Author

I have a rough draft working with your project, I can aim to create a PR in the next couple of days if this interests you.

@mvukov
Copy link
Owner

mvukov commented Mar 25, 2024

Hi, thanks for the initiative. Sure, please open a PR and we can iterate there.

@finn-ball
Copy link
Contributor Author

finn-ball commented Mar 26, 2024

This port is made a lot easier if we manage to port rules_boost:
nelhage/rules_boost#546

Got this merged :)

@mvukov
Copy link
Owner

mvukov commented Jul 6, 2024

Done in #14 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants