Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong expression to detect production mode #95

Closed
jkordas opened this issue Feb 14, 2018 · 1 comment
Closed

Wrong expression to detect production mode #95

jkordas opened this issue Feb 14, 2018 · 1 comment

Comments

@jkordas
Copy link

jkordas commented Feb 14, 2018

In expression:

const inProduction = (typeof process !== "undefined" && process.env.NODE_ENV === "production") || verifyMinified.name === "verifyMinified"

Second condition:

verifyMinified.name === "verifyMinified"

is inappropriate.

It should probably be verifyMinified.name !== "verifyMinified" if I understand correctly ('===' changed to '!==').

@mweststrate
Copy link
Collaborator

Fixed in 1.0.3. Thanks for noticing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants