-
-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
immer autofreeze set to false during production #76
Conversation
Hey @Gregjarvez thanks for the PR! It seems the PR is based on a very old master. Would you be able to reapply the changes to the most recent version of immer? A few comments on the PR: please keep Looking at the autofreeze check, I think your solution to check if the source are minified are pretty nice. So I think the check in the end could be:
I think the typeof checks are nice to add to make it failsafe against build environments that don't substitute process.env, for example when the build system is not webpack. |
sure @mweststrate I will apply those changes soon. however whenever I pull i get merge conflicts and so one although I almost always have not made any changes |
it is probably easier to create a fresh branch based on latest master of
immer and cherry-pick your actual changes
Op za 20 jan. 2018 om 20:37 schreef Coveralls <notifications@github.com>:
… [image: Coverage Status] <https://coveralls.io/builds/15143406>
Coverage increased (+0.01%) to 98.623% when pulling *8a31b05
<8a31b05>
on Gregjarvez:master* into *7290670
<7290670>
on mweststrate:master*.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#76 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABvGhL0TGz76jgZJXgttKIdnRYJmocJaks5tMkCJgaJpZM4RkykM>
.
|
Will do that for my next pull request? @mweststrate |
Manually picked the relevant changes, as that would be less work then merging. Thanks! |
No description provided.