Fixed treating constructor on proxy #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iruca3 thanks! Note that the test suite is failing in the CI. Can you make sure the other tests succeed as well? |
|
Hold on, master seems broken itself. Will investigate |
|
Master has been fixed, could you rebase / merge in the latest master? |
iruca3
force-pushed
the
fix/treating_constructor_on_proxy
branch
from
2483a0f
to
598080b
Compare
|
Thanks! |
|
Fix has been released in 1.0.0
Op vr 26 jan. 2018 om 18:33 schreef Coveralls <notifications@github.com>:
… [image: Coverage Status] <https://coveralls.io/builds/15240456>
Coverage increased (+0.02%) to 98.148% when pulling *598080b
<598080b>
on iruca3:fix/treating_constructor_on_proxy* into *2e8864f
<2e8864f>
on mweststrate:master*.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#81 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABvGhAN_AfShTNfezxHOFIYp2cabJBw2ks5tOgx4gaJpZM4Rtu2L>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed a problem on using constructor for proxy of an array.
It is caused because
'constructor' in state.proxiesalways becometrue.