0.2.8 changes #279
0.2.8 changes #279
Conversation
norrisjeremy
commented
Feb 14, 2023
•
norrisjeremy
commented
- Update dependencies.
- Add additional enforcer rules.
- Remove unneeded junixsocket-native-common dependency.
- Generate CycloneDX SBOM.
- Allow manual dispatch of CI builds.
- Fix CI builds with ubuntu-latest by deleting conflicting users & groups from container.
- Capture maven version info during CI builds.
- Only fork for error-prone where it's needed.
- Define plugin verions and configuration in default build instead within profiles.
- This will help dependabot, as I don't believe it will generate PRs for items that have their versions' only defined within a profile.
- Drop compiler-annotations dependency by disabling classfile warnings.
- Correct license name for JZlib so that it isn't misidentified in SBOM.
|
Not sure why Github Actions isn't picking up the latest commits and attempting a fresh build? |
norrisjeremy
force-pushed
the
20230214
branch
from
c05555d to
b3e584a
Compare
norrisjeremy
force-pushed
the
20230214
branch
from
b3e584a to
e1d40d8
Compare
| @@ -5,6 +5,9 @@ RUN apk update && \ | |||
| apk upgrade && \ | |||
| apk add openssh su-exec && \ | |||
| rm /var/cache/apk/* && \ | |||
| if [ "$testuid" -gt 0 ]; then if egrep "^[^:]+:x:$testuid:" /etc/passwd; then deluser "$(egrep "^[^:]+:x:$testuid:" /etc/passwd | cut -d: -f1)"; fi; fi && \ | |||
| if [ "$testgid" -gt 0 ]; then if egrep "^[^:]+:x:[^:]+:$testgid:" /etc/passwd; then deluser "$(egrep "^[^:]+:x:[^:]+:$testgid:" /etc/passwd | cut -d: -f1)"; fi; fi && \ | |||
| if [ "$testgid" -gt 0 ]; then if egrep "^[^:]+:x:$testgid:" /etc/group; then delgroup "$(egrep "^[^:]+:x:$testgid:" /etc/group | cut -d: -f1)"; fi; fi && \ | |||
There was a problem hiding this comment.
The issue with the latest Ubuntu 22.04 based Github runners turned out to be that the user inside the Azure VM has a GID of 123, which conflicts with the built-in ntp group inside the Alpine container.
This causes the addgroup command below to fail, since it can't add a testuser group with the same GID.
The gross hack above is to check for any UID/GID conflicts inside the Alpine container and remove any conflicting users and/or groups.
| @@ -273,7 +277,6 @@ | |||
| <artifactId>maven-compiler-plugin</artifactId> | |||
| <version>3.10.1</version> | |||
| <configuration> | |||
| <fork>true</fork> | |||
There was a problem hiding this comment.
For whatever reason, maven-compiler-plugin sometimes doesn't display compiler warnings if it tries to fork a javac process.
So I removed it here and opted to just place it inside the errorprone profile, since we only need to fork when using errorprone.
norrisjeremy
force-pushed
the
20230214
branch
from
48c845c to
8c4a1e4
Compare
