Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for javascript and typescript #250

Merged
merged 5 commits into from
Jun 9, 2019

Conversation

hatemhosny
Copy link
Contributor

@hatemhosny hatemhosny commented Jun 8, 2019

this PR adds support for files using IJavascript and ITypescript kernels.

as discussed in #249


This change is Reviewable

@mwouts
Copy link
Owner

mwouts commented Jun 8, 2019

Excellent! Thanks @hatemhosny . I will review this shortly.

@codecov
Copy link

codecov bot commented Jun 9, 2019

Codecov Report

Merging #250 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #250      +/-   ##
==========================================
+ Coverage   99.07%   99.14%   +0.06%     
==========================================
  Files          66       66              
  Lines        6286     6294       +8     
==========================================
+ Hits         6228     6240      +12     
+ Misses         58       54       -4
Impacted Files Coverage Δ
jupytext/kernels.py 91.66% <ø> (ø) ⬆️
tests/test_pep8.py 98.36% <ø> (ø) ⬆️
jupytext/languages.py 100% <ø> (ø) ⬆️
jupytext/contentsmanager.py 98.43% <100%> (ø) ⬆️
jupytext/paired_paths.py 97.36% <100%> (ø) ⬆️
tests/test_mirror.py 100% <100%> (ø) ⬆️
jupytext/metadata_filter.py 100% <100%> (ø) ⬆️
jupytext/cell_reader.py 96.96% <0%> (+0.2%) ⬆️
jupytext/pep8.py 100% <0%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d97aaf...20dc5a9. Read the comment docs.

@mwouts mwouts merged commit 2e6e2c4 into mwouts:master Jun 9, 2019
@mwouts mwouts mentioned this pull request Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants