Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to let pypi know that Jupytext 1.7.1 is the last version with explicit support of Python 2.7 and 3.5 #697

Closed
mwouts opened this issue Dec 28, 2020 · 6 comments · Fixed by #700

Comments

@mwouts
Copy link
Owner

mwouts commented Dec 28, 2020

One of my project that uses Jupytext on the CI is now failing on Python 2.7 and 3.5, with this message:

ERROR: Could not find a version that satisfies the requirement markdown-it-py~=0.6.0 (from jupytext->-r requirements-dev.txt (line 7)) (from versions: none)
ERROR: No matching distribution found for markdown-it-py~=0.6.0 (from jupytext->-r requirements-dev.txt (line 7))
Error: Process completed with exit code 1.

Between Jupytext 1.7.1 and 1.8.0 we removed the explicit support for Python 2.7 and 3.5 (but they should still work), and we replaced the conditional dependency on markdown-it-py when Python>=3.6 with a full dependency.

Still I would like to find a plan to make the itables CI work again on Python 2.7 and 3.5. Maybe we could just provide enough information to pypi to let it download the appropriate version of Jupytext?

@chrisjsewell , do you know how to do that? Maybe an option would be to make the dependency on markdown-it-py~=0.6.0 conditional on python_version >= '3.6' again in a new release of Jupytext 1.8.1? And then in Jupytext 1.8.2 we could remove the condition and take a dependency on Python>=3.6?

@chrisjsewell
Copy link
Contributor

Heya, I note that you do not have in your setup.py python_requires="~=3.6",, which might help

@mwouts
Copy link
Owner Author

mwouts commented Jan 3, 2021

Hi @chrisjsewell , yes I agree, but I think that before that, we need to package a version that will work again with Python < 3.6, otherwise I am afraid that pypi will still try to install Jupytext 1.8.0 when called from Python 2.7 or 3.5. I'll try to do this with cbd0400.

Then I'll add python_requires >= '3.6' to both the setup.py and requirements.txt files. Or python_requires="~=3.6" as you suggest? What is the difference?

@chrisjsewell
Copy link
Contributor

~=3.6 is the same as >=3.6,<4

@mwouts
Copy link
Owner Author

mwouts commented Jan 3, 2021

The first half of the plan worked... the CI for my other project is green now 😄

@mwouts
Copy link
Owner Author

mwouts commented Jan 4, 2021

And the second half worked as well 😌 !

In that run the Python 3.5 test suite was using Jupytext 1.8.1, while the Python 3.7 suite was using Jupytext 1.8.2.

@chrisjsewell
Copy link
Contributor

Looks good to me 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants