From 1e0e64d77b850eaa170b469b631122ce4587d3ea Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Max=20Fr=C3=B6hlich?= <maxbruchmann@gmail.com>
Date: Mon, 1 Jan 2024 23:25:18 +0100
Subject: [PATCH] refactor: notation validator tests

---
 .../validator/notation_validator_test.go      | 127 +++++++++++++-----
 1 file changed, 91 insertions(+), 36 deletions(-)

diff --git a/admissionctrl/validator/notation_validator_test.go b/admissionctrl/validator/notation_validator_test.go
index e71e385..5f6ad3b 100644
--- a/admissionctrl/validator/notation_validator_test.go
+++ b/admissionctrl/validator/notation_validator_test.go
@@ -7,78 +7,133 @@ import (
 
 	"github.com/hashicorp/go-hclog"
 	"github.com/hashicorp/nomad/api"
-	"github.com/stretchr/testify/mock"
 	"github.com/stretchr/testify/require"
 )
 
-type MockVerifier struct {
-	mock.Mock
+type DummyVerifier struct {
 }
 
-func (m *MockVerifier) VerifyImage(ctx context.Context, imageReference string) error {
-	args := m.Called(ctx, imageReference)
-	return args.Error(0)
+func (m *DummyVerifier) VerifyImage(ctx context.Context, imageReference string) error {
+
+	if imageReference == "invalidimage:latest" {
+		return errors.New("invalid image")
+	}
+
+	return nil
 }
 
 func TestNotationValidatorValidate(t *testing.T) {
 
 	tt := []struct {
-		name          string
-		image         string
-		verifierError error
+		name string
+
+		expectedErrors []error
+
+		tasks []struct {
+			driver string
+			image  string
+		}
 	}{
 		{
-			name:  "valid image",
-			image: "myimage",
+			name: "valid image",
+			tasks: []struct {
+				driver string
+				image  string
+			}{
+
+				{
+					driver: "docker",
+					image:  "validimage:latest",
+				},
+			},
+			expectedErrors: nil,
+		},
+		{
+			name: "invalid image",
+			tasks: []struct {
+				driver string
+				image  string
+			}{
+
+				{
+					driver: "docker",
+					image:  "invalidimage:latest",
+				},
+			},
+			expectedErrors: []error{
+				errors.New("invalid image"),
+			},
+		},
+		{
+			name: "invalid image in second task",
+			tasks: []struct {
+				driver string
+				image  string
+			}{
+				{
+					driver: "docker",
+					image:  "validimage:latest",
+				},
+				{
+					driver: "docker",
+					image:  "invalidimage:latest",
+				},
+			},
+			expectedErrors: []error{
+				errors.New("invalid image"),
+			},
 		},
 		{
-			name:          "invalid image",
-			image:         "myimage",
-			verifierError: errors.New("invalid image"),
+			name: "non docker task",
+			tasks: []struct {
+				driver string
+				image  string
+			}{
+				{
+					driver: "magic",
+				},
+			},
+			expectedErrors: nil,
 		},
 	}
 
 	for _, tc := range tt {
 		t.Run(tc.name, func(t *testing.T) {
-			mockImageVerifier := new(MockVerifier)
-
-			mockImageVerifier.On("VerifyImage", mock.Anything, tc.image).Return(tc.verifierError)
+			mockImageVerifier := new(DummyVerifier)
 
 			notationValidator := &NotationValidator{
 				logger:   nil,
 				name:     "notation",
 				verifier: mockImageVerifier,
 			}
-			errors, err := notationValidator.Validate(&api.Job{
-				TaskGroups: []*api.TaskGroup{
-					{
-						Tasks: []*api.Task{
-							{
-
-								Config: map[string]interface{}{
-									"image": tc.image,
-								},
+
+			groups := []*api.TaskGroup{}
+			for _, task := range tc.tasks {
+				groups = append(groups, &api.TaskGroup{
+					Tasks: []*api.Task{
+						{
+							Driver: task.driver,
+							Config: map[string]interface{}{
+								"image": task.image,
 							},
 						},
 					},
-				},
+				})
+			}
+
+			errors, err := notationValidator.Validate(&api.Job{
+				TaskGroups: groups,
 			})
+			require.Equal(t, tc.expectedErrors, errors)
 			require.NoError(t, err)
 
-			if tc.verifierError == nil {
-				require.Empty(t, errors)
-			} else {
-				require.Equal(t, []error{
-					tc.verifierError,
-				}, errors)
-			}
 		})
 	}
 
 }
 
 func TestNewNotationValidator(t *testing.T) {
-	mockImageVerifier := new(MockVerifier)
+	mockImageVerifier := new(DummyVerifier)
 
 	notationValidator := NewNotationValidator(hclog.NewNullLogger(), "notation", mockImageVerifier)
 	require.Equal(t, mockImageVerifier, notationValidator.verifier)
@@ -86,7 +141,7 @@ func TestNewNotationValidator(t *testing.T) {
 	require.NotNil(t, notationValidator.logger)
 }
 func TestNotationValidatorName(t *testing.T) {
-	mockImageVerifier := new(MockVerifier)
+	mockImageVerifier := new(DummyVerifier)
 
 	notationValidator := &NotationValidator{
 		logger:   nil,