Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyicat-plus update #6

Open
antolinos opened this issue Dec 10, 2024 · 4 comments · May be fixed by #10
Open

pyicat-plus update #6

antolinos opened this issue Dec 10, 2024 · 4 comments · May be fixed by #10
Assignees

Comments

@antolinos
Copy link
Contributor

pyicat-plus has changed the API. This MR adapts the MXCuBE code to support such version:
https://gitlab.esrf.fr/icat/pyicat-plus/-/merge_requests/110

@antolinos antolinos self-assigned this Dec 10, 2024
@woutdenolf woutdenolf linked a pull request Dec 11, 2024 that will close this issue
@woutdenolf
Copy link
Contributor

What do you mean with changed?

https://gitlab.esrf.fr/icat/pyicat-plus/-/merge_requests/110 (deployed as version 0.4.0) should support the current MXcube usage in this repository.

@antolinos
Copy link
Contributor Author

I mean this:

catalogue_queues: URLs of the ActiveMQ message brokers to be used for the catalogue (DEPRECATED).
catalogue_url: URL of the ICAT+ REST server to be used for accessing the catalogue (DEPRECATED).
tracking_url: URL of the ICAT+ REST server to be used for accessing the catalogue (DEPRECATED).

@woutdenolf
Copy link
Contributor

woutdenolf commented Dec 11, 2024

Ah ok, it is deprecated but not removed yet. Lets go step by step.

@antolinos
Copy link
Contributor Author

Just make sure we do not do things twice. Changes on ICATLIMS have been done:
https://github.com/mxcube/esrf-mxcubecore/pull/7/files

There were tested on Yesterday and will continue being tested today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants