Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on qt view objects and mount_sample #970

Open
marcus-oscarsson opened this issue Jul 11, 2024 · 0 comments
Open

Dependency on qt view objects and mount_sample #970

marcus-oscarsson opened this issue Jul 11, 2024 · 0 comments

Comments

@marcus-oscarsson
Copy link
Member

marcus-oscarsson commented Jul 11, 2024

We are looking into making the mxcubeweb layer associated with the queue a little bit thinner and push down some code into mxcubecore. Its something we wanted to do for a while and its going to be a multi-step process.

One important step in the process would be to get rid of the tight coupling to the qt view objects. There is a good example in Sample.mount_sample:

centring_method = view.listView().parent().parent().centring_method

It would already be good if we could start with Sample.mount_sample method. I would suggest to remove the view argument entirely and replace the setText with a signal. The centering method in the example above should be replaced with a setting variable accessible with ie. HWR.beamline.sample_view or similar.

This would require some testing on the Qt side, something I cant do with full coverage so we would need some help from you Qt developers here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant