You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We are looking into making the mxcubeweb layer associated with the queue a little bit thinner and push down some code into mxcubecore. Its something we wanted to do for a while and its going to be a multi-step process.
One important step in the process would be to get rid of the tight coupling to the qt view objects. There is a good example in Sample.mount_sample:
It would already be good if we could start with Sample.mount_sample method. I would suggest to remove the view argument entirely and replace the setText with a signal. The centering method in the example above should be replaced with a setting variable accessible with ie. HWR.beamline.sample_view or similar.
This would require some testing on the Qt side, something I cant do with full coverage so we would need some help from you Qt developers here.
The text was updated successfully, but these errors were encountered:
We are looking into making the mxcubeweb layer associated with the queue a little bit thinner and push down some code into mxcubecore. Its something we wanted to do for a while and its going to be a multi-step process.
One important step in the process would be to get rid of the tight coupling to the qt view objects. There is a good example in
Sample.mount_sample
:mxcubecore/mxcubecore/queue_entry/base_queue_entry.py
Line 840 in e78be97
It would already be good if we could start with
Sample.mount_sample
method. I would suggest to remove theview
argument entirely and replace thesetText
with a signal. The centering method in the example above should be replaced with a setting variable accessible with ie.HWR.beamline.sample_view
or similar.This would require some testing on the Qt side, something I cant do with full coverage so we would need some help from you Qt developers here.
The text was updated successfully, but these errors were encountered: