From ab88ee699ac370c50851d3f3e63b613f60f2b4dd Mon Sep 17 00:00:00 2001 From: Max Inden Date: Tue, 4 Apr 2023 13:10:30 +0200 Subject: [PATCH] fix(versions): disable webrtc tests (#160) This commit disables the WebRTC tests for rust-libp2p v0.50.0 and v0.51.0 and chromium-js v0.41.0 and v0.42.0. Neither of these support the new `/webrtc-direct` (see https://github.com/multiformats/multiaddr/pull/150/#issuecomment-1468791586 for context on rename). The missing support is blocking https://github.com/libp2p/rust-libp2p/pull/3688 namely to upgrade to using `/webrtc-direct`. (Note that this is only blocking CI. Users can already use `/webrtc-direct` with the latest released rust-libp2p.) We will backport `/webrtc-direct` support to the rust-libp2p `v0.51.0` interop binary and then re-enable it here. Instead of disabling the versions with missing support for `/webrtc-direct` we could as well patch our interoperability test logic. For the sake of simplicity, I am proposing simply disabling the versions for now. --- multidim-interop/versions.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/multidim-interop/versions.ts b/multidim-interop/versions.ts index 1f1c4bae1..8987367ca 100644 --- a/multidim-interop/versions.ts +++ b/multidim-interop/versions.ts @@ -40,14 +40,14 @@ export const versions: Array = [ { id: "rust-v0.50.0", containerImageID: rustv050.imageID, - transports: ["ws", "tcp", "quic-v1", "webrtc"], + transports: ["ws", "tcp", "quic-v1"], secureChannels: ["tls", "noise"], muxers: ["mplex", "yamux"], }, { id: "rust-v0.51.0", containerImageID: rustv051.imageID, - transports: ["ws", "tcp", "quic-v1", "webrtc"], + transports: ["ws", "tcp", "quic-v1"], secureChannels: ["tls", "noise"], muxers: ["mplex", "yamux"], }, @@ -68,14 +68,14 @@ export const versions: Array = [ { id: "chromium-js-v0.41.0", containerImageID: chromiumJsV041.imageID, - transports: [{ name: "webtransport", onlyDial: true }, { name: "webrtc", onlyDial: true }], + transports: [{ name: "webtransport", onlyDial: true }], secureChannels: [], muxers: [] }, { id: "chromium-js-v0.42.0", containerImageID: chromiumJsV042.imageID, - transports: [{ name: "webtransport", onlyDial: true }, { name: "webrtc", onlyDial: true }, { name: "wss", onlyDial: true }], + transports: [{ name: "webtransport", onlyDial: true }, { name: "wss", onlyDial: true }], secureChannels: ["noise"], muxers: ["mplex", "yamux"] },