From fccb8a12ae149cc1943866e16044461f52204ef2 Mon Sep 17 00:00:00 2001 From: Playwright Service <89237858+playwrightmachine@users.noreply.github.com> Date: Fri, 20 Sep 2024 08:28:46 -0700 Subject: [PATCH] feat(webkit): roll to r2080 (#32721) Signed-off-by: Max Schmitt Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Max Schmitt --- packages/playwright-core/browsers.json | 2 +- tests/library/browsercontext-storage-state.spec.ts | 8 ++------ tests/library/trace-viewer.spec.ts | 4 +++- 3 files changed, 6 insertions(+), 8 deletions(-) diff --git a/packages/playwright-core/browsers.json b/packages/playwright-core/browsers.json index 010068cd7e8a5..5fd29277001c8 100644 --- a/packages/playwright-core/browsers.json +++ b/packages/playwright-core/browsers.json @@ -27,7 +27,7 @@ }, { "name": "webkit", - "revision": "2079", + "revision": "2080", "installByDefault": true, "revisionOverrides": { "mac10.14": "1446", diff --git a/tests/library/browsercontext-storage-state.spec.ts b/tests/library/browsercontext-storage-state.spec.ts index df56ae974097c..02db42506dd50 100644 --- a/tests/library/browsercontext-storage-state.spec.ts +++ b/tests/library/browsercontext-storage-state.spec.ts @@ -277,9 +277,7 @@ it('should work when service worker is intefering', async ({ page, context, serv expect(storageState.origins[0].localStorage[0]).toEqual({ name: 'foo', value: 'bar' }); }); -it('should set local storage in third-party context', async ({ contextFactory, server, browserName }) => { - it.fixme(browserName === 'webkit', 'look into setStorageBlockingPolicy'); - +it('should set local storage in third-party context', async ({ contextFactory, server }) => { const context = await contextFactory({ storageState: { cookies: [], @@ -303,9 +301,7 @@ it('should set local storage in third-party context', async ({ contextFactory, s await context.close(); }); -it('should roundtrip local storage in third-party context', async ({ page, contextFactory, server, browserName }) => { - it.fixme(browserName === 'webkit', 'look into setStorageBlockingPolicy'); - +it('should roundtrip local storage in third-party context', async ({ page, contextFactory, server }) => { await page.goto(server.EMPTY_PAGE); const frame = await attachFrame(page, 'frame1', server.CROSS_PROCESS_PREFIX + '/empty.html'); await frame.evaluate(() => window.localStorage.setItem('name1', 'value1')); diff --git a/tests/library/trace-viewer.spec.ts b/tests/library/trace-viewer.spec.ts index 780e9473feb94..347042d48c6d6 100644 --- a/tests/library/trace-viewer.spec.ts +++ b/tests/library/trace-viewer.spec.ts @@ -130,7 +130,9 @@ test('should complain about newer version of trace in old viewer', async ({ show test('should properly synchronize local and remote time', async ({ showTraceViewer, asset }, testInfo) => { const traceViewer = await showTraceViewer([asset('trace-remote-time-diff.zip')]); // The total duration should be sub 10s, rather than 16h. - await expect(traceViewer.page.locator('.timeline-time').last()).toHaveText('8.5s'); + await expect.poll(async () => + parseInt(await traceViewer.page.locator('.timeline-time').last().innerText(), 10) + ).toBeLessThan(10); }); test('should contain action info', async ({ showTraceViewer }) => {