Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need tests for ColumnSpecialization and ParameterSpecialization #161

Closed
Abscissa opened this issue Feb 7, 2018 · 2 comments
Closed

Need tests for ColumnSpecialization and ParameterSpecialization #161

Abscissa opened this issue Feb 7, 2018 · 2 comments
Milestone

Comments

@Abscissa
Copy link

Abscissa commented Feb 7, 2018

Ugh, don't wanna, but it'd probably be best to have this in before starting on #144...

@Abscissa Abscissa added this to the v2.1.0 milestone Feb 7, 2018
@Abscissa
Copy link
Author

Abscissa commented Feb 9, 2018

Whelp, tests for both of these have been added (as well as a fix for a bug it uncovered in ParameterSpecialization's implementation), but doing so revealed something quite interesting:

Turns out, despite having already been documented, ColumnSpecialization's chunked transfer (the only feature of ColumnSpecialization) was never actually implemented.

Sure, I'd seen the "//TODO: support chunk delegate" buried in one function, but I'd just assumed that was referring to supporting it for some particular edge case.

Fun times with inherited codebases, amiright? :)

@Abscissa
Copy link
Author

Abscissa commented Feb 9, 2018

Closed via cedb4a1

@Abscissa Abscissa closed this as completed Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant