Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AWS Comprehend Node): Add paired item support #10015

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Conversation

ShireenMissi
Copy link
Contributor

@ShireenMissi ShireenMissi commented Jul 11, 2024

Summary

This PR Adds support for paired items to The AWS Comprehend Node.

Note:
This PR includes the addition of a test for the node. While this test is not comprehensive, it represents an improvement from having no tests at all for this node. It serves as an initial step towards better test coverage and should help in identifying any issues related to this node.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1459/aws-comprehend-add-paired-item-support

Community: https://community.n8n.io/t/issue-with-passing-data-to-future-nodes/49481/7

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Tests included.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Jul 11, 2024
Copy link
Contributor

@michael-radency michael-radency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pairedItems fix looks good, but test need an update

Copy link
Contributor

@michael-radency michael-radency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Jul 12, 2024

4 flaky tests on run #5905 ↗︎

0 400 0 0 Flakiness 4

Details:

🌳 ndvpanels-refactor 🖥️ browsers:node18.12.0-chrome107 🤖 schedule 🗃️ e2e/*
Project: n8n Commit: bbf1dac852
Status: Passed Duration: 05:21 💡
Started: Jul 12, 2024 10:18 AM Ended: Jul 12, 2024 10:23 AM
Flakiness  5-ndv.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
NDV > Stop listening for trigger event from NDV Screenshots Video
Flakiness  10-undo-redo.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Undo/Redo > should undo/redo adding connected nodes Test Replay Screenshots Video
Flakiness  24-ndv-paired-item.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > resolves expression with default item when input node is not parent, while still pairing items Test Replay Screenshots Video

Review all test suite changes for PR #10015 ↗︎

@ShireenMissi ShireenMissi merged commit 470d496 into master Jul 12, 2024
27 checks passed
@ShireenMissi ShireenMissi deleted the node-1459 branch July 12, 2024 10:11
@github-actions github-actions bot mentioned this pull request Jul 17, 2024
@janober
Copy link
Member

janober commented Jul 17, 2024

Got released with n8n@1.51.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants