Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Make schema view use the correct output #10016

Merged

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Jul 11, 2024

Summary

Schema view was always showing the data from the first output

Added e2e test to cover this

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1486/schema-view-schema-taken-from-wrong-output-branch

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jul 11, 2024
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Jul 11, 2024

2 flaky tests on run #5893 ↗︎

0 400 0 0 Flakiness 2

Details:

🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Project: n8n Commit: c29664d688
Status: Passed Duration: 05:49 💡
Started: Jul 12, 2024 3:11 AM Ended: Jul 12, 2024 3:17 AM
Flakiness  e2e/5-ndv.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
NDV > Stop listening for trigger event from NDV Screenshots Video

Review all test suite changes for PR #10016 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@elsmr elsmr merged commit c29664d into master Jul 11, 2024
27 checks passed
@elsmr elsmr deleted the node-1486-schema-view-schema-taken-from-wrong-output-branch branch July 11, 2024 15:36
@github-actions github-actions bot mentioned this pull request Jul 17, 2024
@janober
Copy link
Member

janober commented Jul 17, 2024

Got released with n8n@1.51.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants