fix(AMQP Trigger Node): Manual execution updated error reduced wait time #10035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-radency
added
n8n team
Co-authored-by: Shireen Missi <94372015+ShireenMissi@users.noreply.github.com>
Co-authored-by: Shireen Missi <94372015+ShireenMissi@users.noreply.github.com>
ShireenMissi
approved these changes
Jul 12, 2024
|
|
4 flaky tests on run #5917 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
10-undo-redo.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Undo/Redo > should undo/redo adding nodes |
Test Replay
Screenshots
Video
|
|
30-editor-after-route-changes.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Editor actions should work > after saving a new workflow |
Test Replay
Screenshots
Video
|
|
24-ndv-paired-item.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #10035 ↗︎
…amqp-trigger-manual-executions-cant-be-stopped
ShireenMissi
approved these changes
Jul 12, 2024
|
✅ All Cypress E2E specs passed |
michael-radency
deleted the
node-813-amqp-trigger-manual-executions-cant-be-stopped
branch
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reduced wait time for message
Use
NodeOperationErrorto prevent obfuscationRelated Linear tickets, Github issues, and Community forum posts
https://community.n8n.io/t/amqp-trigger-does-not-close-a-connection-when-triggered-manually/30872/4
https://linear.app/n8n/issue/NODE-813/amqp-trigger-manual-executions-cant-be-stopped