-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(editor): Handle disabled nodes in schema view #10052
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
|
2 flaky tests on run #5965 ↗︎
Details:
e2e/5-ndv.cy.ts • 2 flaky tests
Review all test suite changes for PR #10052 ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a minor comment
Co-authored-by: Shireen Missi <94372015+ShireenMissi@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
✅ All Cypress E2E specs passed |
Got released with |
Summary
Schema view should still render a list of nodes when the previous node is disabled.
Disabled nodes should be marked Deactivated and have a description when expanded:
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-1496/schema-view-handle-disabled-nodes
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)