fix(Email Trigger (IMAP) Node): Reconnect not working correctly #10064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netroy
approved these changes
Jul 15, 2024
netroy
changed the title
4 flaky tests on run #5941 ↗︎
Details:
|
||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Undo/Redo > should undo/redo adding nodes |
Test Replay
Screenshots
Video
|
|
5-ndv.cy.ts • 2 flaky tests
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
20-workflow-executions.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Current Workflow Executions > should auto load more items if there is space and auto scroll |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #10064 ↗︎
|
✅ All Cypress E2E specs passed |
Merged
|
Got released with |
|
Thanks! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On disconnect even with the reconnect option enabled the node is not connecting again so the workflow shows as being active but isn't.
To fix this issue, the call to closeFunction upon IMAP connection errors is removed. This change prevents the workflow from being deactivated.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-1400/imap-node-reconnect-not-working-correctly
GH Issue:
#9666
Community Issue:
https://community.n8n.io/t/n8n-bug-report-imap-trigger-not-working-after-a-period-of-time/47796
https://community.n8n.io/t/imap-trigger-not-working-after-a-period-of-time/49470
Zammad:
https://support.n8n.io/#ticket/zoom/6159
https://support.n8n.io/#ticket/zoom/6184
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)