Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Introduce DB health check #10661

Merged
merged 2 commits into from
Sep 5, 2024
Merged

feat(core): Introduce DB health check #10661

merged 2 commits into from
Sep 5, 2024

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Sep 4, 2024

Summary

Introduce /healthz/readiness for monitoring DB state. We cannot yet integrate this into /healthz for this reason.

Related Linear tickets, Github issues, and Community forum posts

#10274

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Sep 4, 2024
@ivov ivov marked this pull request as ready for review September 4, 2024 15:08
Copy link

cypress bot commented Sep 5, 2024

n8n    Run #6749

Run Properties:  status check passed Passed #6749  •  git commit e4d281e27c: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Project n8n
Branch Review db-healthcheck
Run status status check passed Passed #6749
Run duration 04m 42s
Commit git commit e4d281e27c: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Committer Iván Ovejero
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 423
View all changes introduced in this branch ↗︎

Copy link
Contributor

github-actions bot commented Sep 5, 2024

✅ All Cypress E2E specs passed

@ivov ivov merged commit a8e80d0 into master Sep 5, 2024
32 checks passed
@ivov ivov deleted the db-healthcheck branch September 5, 2024 09:04
@github-actions github-actions bot mentioned this pull request Sep 5, 2024
@janober
Copy link
Member

janober commented Sep 5, 2024

Got released with n8n@1.58.0

1 similar comment
@janober
Copy link
Member

janober commented Sep 5, 2024

Got released with n8n@1.58.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants