Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(editor): Hide data mapping tooltip in credential edit modal #11356

Merged
merged 2 commits into from
Oct 24, 2024
Merged

fix(editor): Hide data mapping tooltip in credential edit modal #11356

merged 2 commits into from
Oct 24, 2024

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Oct 23, 2024

Summary

data mapping tooltip would show up in credential modal:

image

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1835/data-mapping-tooltip-appears-in-cred-fields

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Oct 23, 2024
@ShireenMissi ShireenMissi added the tests-needed This PR needs additional tests label Oct 24, 2024
ShireenMissi
ShireenMissi approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@cypress Cypress
Copy link

cypress bot commented Oct 24, 2024

n8n    Run #7540

Run Properties:  status check passed Passed #7540  •  git commit decfa9b53e: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Project n8n
Branch Review node-1835-data-mapping-tooltip-appears-in-cred-fields
Run status status check passed Passed #7540
Run duration 04m 18s
Commit git commit decfa9b53e: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Committer Elias Meire
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 458
View all changes introduced in this branch ↗︎

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@ShireenMissi ShireenMissi merged commit ff14dcb into master Oct 24, 2024
33 checks passed
@ShireenMissi ShireenMissi deleted the node-1835-data-mapping-tooltip-appears-in-cred-fields branch October 24, 2024 12:22
This was referenced Oct 28, 2024
Closed
Merged
@janober
Copy link
Member

janober commented Oct 31, 2024

Got released with n8n@1.66.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShireenMissi ShireenMissi ShireenMissi approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released tests-needed This PR needs additional tests ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elsmr @janober @ShireenMissi