Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Improve formatting of expired trial error message #11708

Conversation

igatanasov
Copy link
Contributor

@igatanasov igatanasov commented Nov 12, 2024

Summary

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@igatanasov igatanasov requested a review from mutdmour November 12, 2024 20:00
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Nov 12, 2024
@igatanasov igatanasov requested a review from fedme November 12, 2024 20:01
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@igatanasov igatanasov force-pushed the ado-2794-bug-when-trial-ended-and-you-execute-a-node-we-show-the branch 2 times, most recently from ab92f4b to db4396a Compare November 13, 2024 20:41
@igatanasov igatanasov force-pushed the ado-2794-bug-when-trial-ended-and-you-execute-a-node-we-show-the branch from db4396a to 76cad53 Compare November 13, 2024 21:36
@igatanasov igatanasov requested a review from netroy November 13, 2024 22:16
Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇🏽

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Nov 14, 2024

n8n    Run #7881

Run Properties:  status check failed Failed #7881  •  git commit 47e80f70a6: 🌳 ado-2808-1 🖥️ browsers:node18.12.0-chrome107 🤖 schedule 🗃️ e2e/*
Project n8n
Branch Review ado-2808-1
Run status status check failed Failed #7881
Run duration 04m 40s
Commit git commit 47e80f70a6: 🌳 ado-2808-1 🖥️ browsers:node18.12.0-chrome107 🤖 schedule 🗃️ e2e/*
Committer Mutasem Aldmour
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 4
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 473
View all changes introduced in this branch ↗︎

Tests for review

Failed  17-workflow-tags.cy.ts • 1 failed test

View Output Video

Test Artifacts
Workflow tags > should detach a tag inline by clicking on dropdown list item Test Replay Screenshots Video
Failed  36-versions.cy.ts • 0 failed tests

View Output

Test Artifacts
Flakiness  24-ndv-paired-item.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
NDV > maps paired input and output items Test Replay Screenshots Video
NDV > maps paired input and output items based on selected input node Test Replay Screenshots Video
Flakiness  30-langchain.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Langchain Integration > should be able to open and execute Agent node Test Replay Screenshots Video
Flakiness  30-editor-after-route-changes.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Editor actions should work > after switching between Editor and Debug Test Replay Screenshots Video

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

✅ All Cypress E2E specs passed

@igatanasov igatanasov merged commit 8a0ad0f into master Nov 14, 2024
47 checks passed
@igatanasov igatanasov deleted the ado-2794-bug-when-trial-ended-and-you-execute-a-node-we-show-the branch November 14, 2024 11:19
@github-actions github-actions bot mentioned this pull request Nov 20, 2024
@janober
Copy link
Member

janober commented Nov 20, 2024

Got released with n8n@1.69.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants