-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(editor): add automatic credential selection for new nodes #2746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-radency
added
ui
Enhancement in /editor-ui or /design-system
n8n team
Authored by the n8n team
labels
Feb 1, 2022
mutdmour
reviewed
Feb 1, 2022
…nt/automatic-credential-selection
…hen one existing credential
mutdmour
reviewed
Feb 9, 2022
…nt/automatic-credential-selection
mutdmour
reviewed
Feb 17, 2022
…atic-credential-selection
…nt/automatic-credential-selection
mutdmour
reviewed
Mar 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. just one last comment.
…nt/automatic-credential-selection
mutdmour
reviewed
Mar 3, 2022
…nt/automatic-credential-selection
…atic-credential-selection
mutdmour
changed the title
⚡ Implemented automatic credential selection in nodes N8N-2895
feat(editor): add automatic credential selection
Oct 13, 2022
cstuncsik
approved these changes
Oct 13, 2022
mutdmour
changed the title
feat(editor): add automatic credential selection
feat(editor): add automatic credential selection for new nodes
Oct 17, 2022
n8n-assistant
bot
added
the
Upcoming Release
Will be part of the upcoming release
label
Oct 17, 2022
Got released with |
valya
pushed a commit
to valya/n8n
that referenced
this pull request
Nov 8, 2022
…o#2746) * ⚡ implemented automatic credential selection in nodes * ⚡ fixed implementation * ⚡ fixed linter error * 🔨 in progress, removed watching for auth type, added check for more then one existing credential * 🔨 removed console log * 🔨 changing auth method for one that have default credential * 🔨 credentials will be set only at node creation time * 🔨 fixed authentication parameter assigment for nodes that does not have it * ⚡ better properties checking * 🔨 improvements * 🔨 extracted into function, fix issue with assigning hidden credentials * remove console log * fix bug with multiple creds * fix defaults issue * remove import * simplify to just auth * Revert "simplify to just auth" 042c9cc * fix get Co-authored-by: Mutasem <mutdmour@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.