Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): add automatic credential selection for new nodes #2746

Merged
merged 27 commits into from
Oct 17, 2022

Conversation

michael-radency
Copy link
Contributor

No description provided.

@michael-radency michael-radency added ui Enhancement in /editor-ui or /design-system n8n team Authored by the n8n team labels Feb 1, 2022
packages/editor-ui/src/components/mixins/nodeBase.ts Outdated Show resolved Hide resolved
packages/editor-ui/src/views/NodeView.vue Outdated Show resolved Hide resolved
packages/editor-ui/src/views/NodeView.vue Outdated Show resolved Hide resolved
Copy link
Contributor

@mutdmour mutdmour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. just one last comment.

packages/editor-ui/src/views/NodeView.vue Show resolved Hide resolved
@mutdmour mutdmour changed the title ⚡ Implemented automatic credential selection in nodes N8N-2895 feat(editor): add automatic credential selection Oct 13, 2022
@mutdmour mutdmour changed the title feat(editor): add automatic credential selection feat(editor): add automatic credential selection for new nodes Oct 17, 2022
@mutdmour mutdmour merged commit d31fbbb into master Oct 17, 2022
@mutdmour mutdmour deleted the enhancement/automatic-credential-selection branch October 17, 2022 11:39
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Oct 17, 2022
@janober
Copy link
Member

janober commented Oct 21, 2022

Got released with n8n@0.199.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Oct 21, 2022
valya pushed a commit to valya/n8n that referenced this pull request Nov 8, 2022
…o#2746)

* ⚡ implemented automatic credential selection in nodes

* ⚡ fixed implementation

* ⚡ fixed linter error

* 🔨 in progress, removed watching for auth type, added check for more then one existing credential

* 🔨 removed console log

* 🔨 changing auth method for one that have default credential

* 🔨 credentials will be set only at node creation time

* 🔨 fixed authentication parameter assigment for nodes that does not have it

* ⚡ better properties checking

* 🔨 improvements

* 🔨 extracted into function, fix issue with assigning hidden credentials

* remove console log

* fix bug with multiple creds

* fix defaults issue

* remove import

* simplify to just auth

* Revert "simplify to just auth"

042c9cc

* fix get

Co-authored-by: Mutasem <mutdmour@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants