Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FunctionItem getBinaryData() empty when default binary data mode set to filesystem. #3618

Closed
rhyswilliamsza opened this issue Jun 30, 2022 · 1 comment

Comments

@rhyswilliamsza
Copy link
Contributor

Describe the bug
FunctionItem getBinaryData() empty when default binary data mode set to filesystem, though data is visible in the node input.

To Reproduce
Steps to reproduce the behavior:

  1. Set N8N_DEFAULT_BINARY_DATA_MODE to filesystem
  2. Tie together a stream that includes a node that outputs binary data, as well as a FunctionItem node that accepts this binary data.
  3. Call getBinaryData() in your function. The data element is empty and the binary data is inaccessible.

Expected behavior
If N8N_DEFAULT_BINARY_DATA_MODE is left to memory, the getBinaryData() helper method correctly returns binary data.

Environment (please complete the following information):

  • OS: Official Docker image on Linux x64
  • n8n Version: 0.183.0
  • Node.js Version: Official Docker Image Embedded NodeJs
  • Database system: MySQL
  • Operation mode: Queue, but also happens on main.
@Joffcom
Copy link
Member

Joffcom commented Jan 18, 2023

Hey @rhyswilliamsza,

Thanks again for the PR on this one, It looks like our link didn't kick in to automatically close this one so I will get it done now 👍🏻

@Joffcom Joffcom closed this as completed Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants