-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
N8n 4040 data mapping #3708
N8n 4040 data mapping #3708
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! 🙌 Really looking forward to this feature.
I found a few nitpicks and possible refactor possibilities so once that is discussed/addressed this is good to go as far as I am concerned.
Some more stuff unrelated to code:
- Personally, I expect from dragged value to overwrite current expression, not append to it so I find it confusing and a bit annoying that I have to go to editor and remove previous values. This is especially confusing since most of the time, only a single value (data pill) is visible in input field.
- Just found out that
combine
field in theIF
node accepts expressions. Haven't found anything regarding possible values other thatALL
andANY
. Is this a bug?
I agree with you.. discussed this a lot but Max is confident in this.
not a bug.. can be disabled directly in if node definition if it's not supposed to |
Amazing! Just got merged. |
Got released with |
No description provided.